Attachment 116499 Details for Bug 27608 – Bug 27608: Corrects 'accepted by' inconsistency in suggestion.tt

[patch] Bug 27608: Corrects 'accepted by' inconsistency in suggestion.tt

Bug-27608-Corrects-accepted-by-inconsistency-in-su.patch (text/plain), 2.47 KB, created by Jonathan Druart on 2021-02-08 13:52:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-02-08 13:52:34 UTC

Size: 2.47 KB

patch

obsolete

>From 634c3facd8f9b24392013aac6c82e6d0546127ee Mon Sep 17 00:00:00 2001
>From: Blou <blou@inlibro.com>
>Date: Wed, 3 Feb 2021 11:46:33 -0500
>Subject: [PATCH] Bug 27608: Corrects 'accepted by' inconsistency in
> suggestion.tt
>
>When looking at an accepted suggestion in suggestion.pl, under 'Suggestion management', the displayed cardnumber in parenthesis is the wrong one.  It displays the "suggestedby"'s cardnumber instead of the acceptedby.
>
>Test:
>- create a suggestion in OPAC or staff client with user A.
>- In staff client, go to accept it with User B.
>- Click Edit
>- Under section "Suggestion management", you have a "Accepted on".
>- In the By column, the cardnumber in parenthsis is not the B one.
>- Apply patch, refresh.
>
>Looking at the code patch is self-explanatory.
>
>Sponsored-by: Collecto
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>JD Amended patch: Add sponsor line
>---
> .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt      | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>index 94ed6f6b39..6b1713a773 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>@@ -487,7 +487,7 @@
>                                         <td>
>                                             <input type="hidden" id="acceptedby" name="acceptedby" value="[% acceptedby | html %]"/>
>                                             [% IF ( acceptedby_patron.borrowernumber ) %]
>-                                                <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% acceptedby_patron.borrowernumber | uri %]">[% acceptedby_patron.surname | html %], [% acceptedby_patron.firstname | html %] ([% suggestedby_patron.cardnumber | html %])</a>
>+                                                <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% acceptedby_patron.borrowernumber | uri %]">[% acceptedby_patron.surname | html %], [% acceptedby_patron.firstname | html %] ([% acceptedby_patron.cardnumber | html %])</a>
>                                                 [% Branches.GetName( acceptedby_patron.branchcode ) | html %] ([% acceptedby_patron.category.description | html %])
>                                             [% END %]
>                                         </td>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27608: 116288 | 116341 | 116450 | 116499 | 116974