Attachment 116526 Details for Bug 27403 – Bug 27403: (follow-up) Make basket toolbar and table header work together

[patch] Bug 27403: (follow-up) Make basket toolbar and table header work together

Bug-27403-follow-up-Make-basket-toolbar-and-table-.patch (text/plain), 2.04 KB, created by Katrin Fischer on 2021-02-08 21:01:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2021-02-08 21:01:41 UTC

Size: 2.04 KB

patch

obsolete

>From b335ea8b8e06106acb25fc2004b2eb3be628fd3c Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 19 Jan 2021 14:02:37 +0000
>Subject: [PATCH] Bug 27403: (follow-up) Make basket toolbar and table header
> work together
>
>The fixed header option for DataTables does the same thing that the
>hcSticky jQuery plugin does for us on toolbars, so I've gone through the
>templates looking for places they might conflict.
>
>On the acquisitions basket page we can add a special class,
>"fh-fixedHeader," to the sticky toolbar to tell DataTables that the
>table header should float *below* the toolbar.
>
>To test, apply the patch and go to Acquisitions.
>
>- Locate a vendor and a basket for that vendor with multiple orders.
>- Adjust the browse window height if necessary to trigger vertical
>  scrolling.
>- Confirm that as you scroll down the toolbar (with buttons "Add to
>  basket," "Edit basket," etc) sticks to the top of the browser window.
>- Confirm that as you continue to scroll, the table header sticks below
>  the floating toolbar.
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>index 28567bd827..56462c51d5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>@@ -54,7 +54,7 @@
>         [% UNLESS ( selectbasketg ) %]
>             [% UNLESS ( closedate ) %]
>             [% UNLESS ( delete_confirmed ) %]
>-                <div id="toolbar" class="btn-toolbar">
>+                <div id="toolbar" class="btn-toolbar fh-fixedHeader">
>                     [% IF active %]
>                         <div class="btn-group"><a href="#addtoBasket" role="button" class="btn btn-default" data-toggle="modal"><i class="fa fa-plus"></i> Add to basket</a></div>
>                     [% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27403: 115055 | 115098 | 115314 | 115323 | 115324 | 115333 | 116004 | 116005 | 116524 | 116525 | 116526 | 128685