Attachment 116556 Details for Bug 26057 – Bug 26057: (QA follow-up) Drop test for 'reason'

[patch] Bug 26057: (QA follow-up) Drop test for 'reason'

Bug-26057-QA-follow-up-Drop-test-for-reason.patch (text/plain), 1.46 KB, created by Martin Renvoize (ashimema) on 2021-02-09 11:08:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-02-09 11:08:21 UTC

Size: 1.46 KB

patch

obsolete

>From 1cc12132fcd321f328938bf6d79334e5738701a0 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 21 Jan 2021 14:27:44 +0000
>Subject: [PATCH] Bug 26057: (QA follow-up) Drop test for 'reason'
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>We decided this test was superflous to requirements and as such I've
>removed it as requested.
>
>Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <joonas.kylmala@helsinki.fi>
>---
> t/db_dependent/Koha/Item/Transfer.t | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Item/Transfer.t b/t/db_dependent/Koha/Item/Transfer.t
>index 01a32866fd..1bc6d7fa9f 100755
>--- a/t/db_dependent/Koha/Item/Transfer.t
>+++ b/t/db_dependent/Koha/Item/Transfer.t
>@@ -208,7 +208,7 @@ subtest 'in_transit tests' => sub {
> };
> 
> subtest 'cancel tests' => sub {
>-    plan tests => 6;
>+    plan tests => 5;
> 
>     $schema->storage->txn_begin;
> 
>@@ -256,7 +256,6 @@ subtest 'cancel tests' => sub {
>     $transfer->cancel($cancellation_reason);
>     ok( $transfer->datecancelled, 'Cancellation date set upon call to cancel' );
>     is( $transfer->cancellation_reason, 'Manual', 'Cancellation reason is set');
>-    is( $transfer->reason, 'Manual', 'Reason is not updated by cancelling the transfer' );
> 
>     $schema->storage->txn_rollback;
> };
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26057: 110476 | 110477 | 111279 | 116554 | 116555 | 116556 | 117585 | 117586 | 117587 | 117588 | 117632 | 117633 | 117635