Attachment 116560 Details for Bug 24446 – Bug 24446: Catch daterequested in circ returns

[patch] Bug 24446: Catch daterequested in circ returns

Bug-24446-Catch-daterequested-in-circ-returns.patch (text/plain), 9.58 KB, created by Martin Renvoize (ashimema) on 2021-02-09 11:11:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-02-09 11:11:48 UTC

Size: 9.58 KB

patch

obsolete

>From 10689ed324b37cddd3029d2775d176ed99ba15cc Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 17 Jan 2020 13:58:12 +0000
>Subject: [PATCH] Bug 24446: Catch daterequested in circ returns
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Update C4::Circulation::AddReturn to use Koha::Item->get_transfer to
>find requested transfers and use Koha::Item::Transfer->receipt to complete
>transfer requests if they have arrived at their destination or return the
>relevant 'WrongTransfer', 'WasTransfered' and 'TransferTrigger' messages
>to the end user.
>
>Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <joonas.kylmala@helsinki.fi>
>---
> C4/Circulation.pm                             | 51 ++++++++++++-------
> circ/returns.pl                               |  4 +-
> .../prog/en/modules/circ/returns.tt           | 23 ++++++++-
> 3 files changed, 58 insertions(+), 20 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 7f37b37af9..8cb431015f 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -383,7 +383,7 @@ sub transferbook {
>         ModItemTransfer( $itemnumber, $fbr, $tbr, $trigger );
> 
>         # don't need to update MARC anymore, we do it in batch now
>-        $messages->{'WasTransfered'} = 1;
>+        $messages->{'WasTransfered'} = $tbr;
> 
>     }
>     ModDateLastSeen( $itemnumber );
>@@ -2130,23 +2130,31 @@ sub AddReturn {
>     }
> 
>     # check if we have a transfer for this document
>-    my ($datesent,$frombranch,$tobranch) = GetTransfers( $item->itemnumber );
>+    my $transfer = $item->get_transfer;
> 
>     # if we have a transfer to complete, we update the line of transfers with the datearrived
>     my $is_in_rotating_collection = C4::RotatingCollections::isItemInAnyCollection( $item->itemnumber );
>-    if ($datesent) {
>-        # At this point we will either fill the transfer or it is a wrong transfer
>-        # either way we should not now generate a new transfer
>+    if ($transfer) {
>         $validTransfer = 0;
>-        if ( $tobranch eq $branch ) {
>-            my $sth = C4::Context->dbh->prepare(
>-                "UPDATE branchtransfers SET datearrived = now() WHERE itemnumber= ? AND datearrived IS NULL"
>-            );
>-            $sth->execute( $item->itemnumber );
>-            $messages->{'TransferArrived'} = $frombranch;
>-        } else {
>-            $messages->{'WrongTransfer'}     = $tobranch;
>-            $messages->{'WrongTransferItem'} = $item->itemnumber;
>+        if ( $transfer->in_transit ) {
>+            if ( $transfer->tobranch eq $branch ) {
>+                $transfer->receive;
>+                $messages->{'TransferArrived'} = $transfer->frombranch;
>+            }
>+            else {
>+                $messages->{'WrongTransfer'}     = $transfer->tobranch;
>+                $messages->{'WrongTransferItem'} = $item->itemnumber;
>+            }
>+        }
>+        else {
>+            if ( $transfer->tobranch eq $branch ) {
>+                $transfer->receive;
>+                $messages->{'TransferArrived'} = $transfer->frombranch;
>+            }
>+            else {
>+                $messages->{'WasTransfered'}   = $transfer->tobranch;
>+                $messages->{'TransferTrigger'} = $transfer->reason;
>+            }
>         }
>     }
> 
>@@ -2237,7 +2245,13 @@ sub AddReturn {
>     }
> 
>     # Transfer to returnbranch if Automatic transfer set or append message NeedsTransfer
>-    if ($validTransfer && !$is_in_rotating_collection && ($doreturn or $messages->{'NotIssued'}) and !$resfound and ($branch ne $returnbranch) ){
>+    if ( $validTransfer && !$is_in_rotating_collection
>+        && ( $doreturn or $messages->{'NotIssued'} )
>+        and !$resfound
>+        and ( $branch ne $returnbranch )
>+        and not $messages->{'WrongTransfer'}
>+        and not $messages->{'WasTransfered'} )
>+    {
>         my $BranchTransferLimitsType = C4::Context->preference("BranchTransferLimitsType") eq 'itemtype' ? 'effective_itemtype' : 'ccode';
>         if  (C4::Context->preference("AutomaticItemReturn"    ) or
>             (C4::Context->preference("UseBranchTransferLimits") and
>@@ -2246,7 +2260,8 @@ sub AddReturn {
>             $debug and warn sprintf "about to call ModItemTransfer(%s, %s, %s, %s)", $item->itemnumber,$branch, $returnbranch, $transfer_trigger;
>             $debug and warn "item: " . Dumper($item->unblessed);
>             ModItemTransfer($item->itemnumber, $branch, $returnbranch, $transfer_trigger, { skip_record_index => 1 });
>-            $messages->{'WasTransfered'} = 1;
>+            $messages->{'WasTransfered'} = $returnbranch;
>+            $messages->{'TransferTrigger'} = $transfer_trigger;
>         } else {
>             $messages->{'NeedsTransfer'} = $returnbranch;
>             $messages->{'TransferTrigger'} = $transfer_trigger;
>@@ -3406,7 +3421,9 @@ sub GetTransfers {
>         SELECT datesent,
>                frombranch,
>                tobranch,
>-               branchtransfer_id
>+               branchtransfer_id,
>+               daterequested,
>+               reason
>         FROM branchtransfers
>         WHERE itemnumber = ?
>           AND datearrived IS NULL
>diff --git a/circ/returns.pl b/circ/returns.pl
>index 4e9662024c..7cbbe4df94 100755
>--- a/circ/returns.pl
>+++ b/circ/returns.pl
>@@ -367,7 +367,9 @@ my $reserved = 0;
> if ( $messages->{'WasTransfered'} ) {
>     $template->param(
>         found          => 1,
>-        transfer       => 1,
>+        transfer       => $messages->{'WasTransfered'},
>+        trigger        => $messages->{'TransferTrigger'},
>+        itemnumber     => $itemnumber,
>     );
> }
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index c2bdd03bb9..b5754e8b7f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -106,6 +106,25 @@
>                                 </div> 
>                             [% END # /IF hold_auto_filled %]
> 
>+                            [% IF ( trigger ) %]
>+                                 <div id="transfer-trigger" class="dialog message">
>+                                     <h3>Reason for transfer</h3>
>+                                     <p>
>+                                         [%- SWITCH trigger -%]
>+                                             [%- CASE 'Manual' -%]Manual
>+                                             [%- CASE 'StockrotationAdvance' -%]Stock rotation advance
>+                                             [%- CASE 'StockrotationRepatriation' -%]Stock rotation repatriation
>+                                             [%- CASE 'ReturnToHome' -%]Return to home library
>+                                             [%- CASE 'ReturnToHolding' -%]Return to holding library
>+                                             [%- CASE 'RotatingCollection' -%]Rotating collection
>+                                             [%- CASE 'Reserve' -%]Reserve
>+                                             [%- CASE 'LostReserve' -%]Lost reserve
>+                                             [%- CASE 'CancelReserve' -%]Cancelled reserve
>+                                         [%- END -%]
>+                                     </p>
>+                                 </div>
>+                            [% END %]
>+
>                             [% IF privacy == 2 AND NOT Koha.Preference('AnonymousPatron') %]
>                                 <div class="dialog alert">
>                                     <strong>Error:</strong>
>@@ -538,7 +557,7 @@
> 
>                                                 <div class="modal-header">
>                                                     <h3>
>-                                                        Please return this item to [% Branches.GetName( returnbranch ) | html %]
>+                                                        Please return this item to [% IF transfer %][% Branches.GetName( transfer ) | html %][% ELSE %][% Branches.GetName( returnbranch ) | html %][% END %]
>                                                     </h3>
>                                                 </div>
>                                                 <div class="modal-body">
>@@ -565,7 +584,7 @@
>                                                         <button type="button" data-dismiss="modal" class="btn btn-default deny" name="notransfer" value="No"><i class="fa fa-times"></i> No</button>
>                                                     [% ELSE %]
>                                                         <button type="button" data-dismiss="modal" class="btn btn-default approve"><i class="fa fa-check"></i> OK</button>
>-                                                        <button type="button" data-dismiss="modal" name="dotransfer" class="btn btn-default print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | uri %]&amp;branchcode=[% returnbranch | uri %]&amp;op=slip"><i class="fa fa-print"></i> Print slip</button>
>+                                                        <button type="button" data-dismiss="modal" name="dotransfer" class="btn btn-default print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | uri %]&amp;branchcode=[% transfer | uri %]&amp;op=slip"><i class="fa fa-print"></i> Print slip</button>
>                                                     [% END %]
>                                                     <input type="hidden" name="return_date_override" value="[% return_date_override | html %]" />
>                                                     <input type="hidden" name="return_date_override_remember" value="[% return_date_override_remember | html %]" />
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24446: 105943 | 105944 | 105945 | 107246 | 107247 | 107248 | 107249 | 107250 | 107252 | 107253 | 107254 | 107255 | 107256 | 107301 | 107302 | 107303 | 107304 | 107305 | 110280 | 110281 | 110282 | 110283 | 110533 | 110534 | 110535 | 110536 | 110537 | 110538 | 110539 | 110540 | 110541 | 110542 | 111322 | 116557 | 116558 | 116559 | 116560 | 116561 | 116562 | 116563 | 116564 | 116565 | 116566 | 116567 | 116568 | 116569 | 116570 | 117589 | 117590 | 117591 | 117592 | 117593 | 117594 | 117595 | 117596 | 117597 | 117598 | 117599 | 117600 | 117601 | 117602 | 117603 | 117604 | 117605 | 117606 | 117607 | 120116