Attachment 116576 Details for Bug 27653 – Bug 27653: [Alternate] Use toolbar elements instead of captions

[patch] Bug 27653: [Alternate] Use toolbar elements instead of captions

Bug-27653-Alternate-Use-toolbar-elements-instead-o.patch (text/plain), 2.30 KB, created by Nick Clemens (kidclamp) on 2021-02-09 14:41:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-02-09 14:41:46 UTC

Size: 2.30 KB

patch

obsolete

>From d150a4c19127a12c36a0f065058ad29504fe02d6 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 9 Feb 2021 14:39:35 +0000
>Subject: [PATCH] Bug 27653: [Alternate] Use toolbar elements instead of
> captions
>
>The aqbudgets and aqui-home tables use captions for additional table controls - these are
>more appropriate as a toolbar
>
>To test:
>1 - View the tables on acquisitions home and budgets views
>2 - Note the 'Expand all...' control row
>3 - Apply patch
>4 - The row remains, but is above table rows
>5 - The row is not included when printing or copying the table
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt | 4 ++--
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt  | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt
>index c9b7296017..6c28fe2430 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt
>@@ -79,7 +79,7 @@
> 
>     <div id="BudgetsAndFunds">
>     <table id="accounts">
>-        <caption>
>+        <div class="toolbar">
>           <span class="actions"><a href="#" id="expand_all">Expand all</a>
>           | <a href="#" id="collapse_all">Collapse all</a>
>           | <a href="#" id="hide_inactive">Hide inactive budgets</a>
>@@ -92,7 +92,7 @@
>             </select>
>         </span>
> 
>-        </caption>
>+        </div>
> 
>         <thead>
>         <tr>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt
>index 5eeb57766b..e14d7cd2b5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt
>@@ -53,12 +53,12 @@
> 
> <table id="budgeth" class="group">
>     [% UNLESS budget_period_id %]
>-      <caption>
>+      <div class="toolbar">
>         <span class="actions"><a href="#" id="expand_all">Expand all</a>
>         | <a href="#" id="collapse_all">Collapse all</a>
>         | <a href="#" id="hide_inactive">Hide inactive budgets</a>
>         | <a href="#" id="show_inactive">Show inactive budgets</a></span>
>-      </caption>
>+      </div>
>     [% END %]
>     <thead>
>         <tr>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27653: 116495 | 116530 | 116531 | 116576 | 116611 | 116614 | 116615 | 116690 | 116841 | 116864