Attachment 116757 Details for Bug 26181 – Bug 26181: Regression tests

[patch] Bug 26181: Regression tests

Bug-26181-Regression-tests.patch (text/plain), 1.81 KB, created by Kyle M Hall (khall) on 2021-02-11 14:51:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2021-02-11 14:51:44 UTC

Size: 1.81 KB

patch

obsolete

>From 12756a979f17d13ff6b740cccd45010c831786cf Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 10 Aug 2020 17:30:13 -0300
>Subject: [PATCH] Bug 26181: Regression tests
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> t/db_dependent/api/v1/holds.t | 18 +++++++++++++-----
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
>diff --git a/t/db_dependent/api/v1/holds.t b/t/db_dependent/api/v1/holds.t
>index 7045c2f849..41cf559ca9 100755
>--- a/t/db_dependent/api/v1/holds.t
>+++ b/t/db_dependent/api/v1/holds.t
>@@ -24,6 +24,7 @@ use t::lib::TestBuilder;
> use t::lib::Mocks;
> 
> use DateTime;
>+use Mojo::JSON qw(encode_json);
> 
> use C4::Context;
> use Koha::Patrons;
>@@ -355,15 +356,15 @@ subtest 'test AllowHoldDateInFuture' => sub {
> 
> subtest 'test AllowHoldPolicyOverride' => sub {
> 
>-    plan tests => 5;
>+    plan tests => 7;
> 
>     $dbh->do('DELETE FROM reserves');
> 
>     Koha::CirculationRules->set_rules(
>         {
>-            itemtype     => undef,
>-            branchcode   => undef,
>-            rules        => {
>+            itemtype   => undef,
>+            branchcode => undef,
>+            rules      => {
>                 holdallowed => 1
>             }
>         }
>@@ -384,7 +385,14 @@ subtest 'test AllowHoldPolicyOverride' => sub {
>     t::lib::Mocks::mock_preference( 'AllowHoldPolicyOverride', 1 );
> 
>     $t->post_ok( "//$userid_3:$password@/api/v1/holds" => json => $post_data )
>-      ->status_is(201);
>+      ->status_is(403);
>+
>+    $t->post_ok(
>+        "//$userid_3:$password@/api/v1/holds" => {
>+            'x-koha-override' =>
>+              encode_json( { AllowHoldPolicyOverride => Mojo::JSON->true } )
>+        } => json => $post_data
>+    )->status_is(201);
> };
> 
> $schema->storage->txn_rollback;
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 26181: 108016 | 108017 | 116720 | 116721 | 116757 | 116758 | 116786 | 116787