Bugzilla – Attachment 116842 Details for
Bug 27695
Fix style of messages on Elasticsearch configuration page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27695: Fix style of messages on Elasticsearch configuration page
Bug-27695-Fix-style-of-messages-on-Elasticsearch-c.patch (text/plain), 4.72 KB, created by
Owen Leonard
on 2021-02-12 19:05:33 UTC
(
hide
)
Description:
Bug 27695: Fix style of messages on Elasticsearch configuration page
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2021-02-12 19:05:33 UTC
Size:
4.72 KB
patch
obsolete
>From c0c22b5a2a9be05fc84f457d0314a52d03fb77b6 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 12 Feb 2021 17:08:25 +0000 >Subject: [PATCH] Bug 27695: Fix style of messages on Elasticsearch > configuration page > >This patch makes minor modifications to SCSS and HTML to make messages >on the Elasticsearch configuration page more consistent with other >interfaces. > >To test you should have Elasticsearch selected as your search engine. > >- Apply the patch and rebuild the staff interface CSS > (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) >- Go to Administration -> Search engine configuration (Elasticsearch) >- You should see a full-width "note" style message under the page > heading, "Warning: Any changes..." >- Click the "Reset mappings" button at the bottom of the page. The > confirmation alert you see should appear above the note-style message. >- I'm not sure how to trigger an "error" type message on this page, but > you can test the updated style by going to Administration -> > Currencies and submit a new currency with the same name and symbol as > one which already exists. >--- > .../intranet-tmpl/prog/css/src/staff-global.scss | 3 ++- > .../admin/searchengine/elasticsearch/mappings.tt | 26 +++++++++++++--------- > 2 files changed, 17 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index 84766fd401..3e3f3aa18f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -1801,7 +1801,8 @@ i { > } > } > >-.alert { >+.alert, >+.error { > background: linear-gradient(to bottom, #FEF8D3 0%, #FFEC91 9%, #FFED87 89%, #F9DC00 100%); > border: 1px solid #E0C726; > color: inherit; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt >index 81beb1d311..d1d8405a4f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt >@@ -56,16 +56,7 @@ a.add, a.delete { > [% END %] > > <h1>Search engine configuration (Elasticsearch)</h1> >- <div class="dialog message"> >- Warning: Any changes to the configuration will only take effect after a full reindex. Until then searching may not work correctly. > >- <p>Weight: define weight as a positive number. Higher numbers indicate increased relevancy. >- <strong>Note that fields weighting works only for simple search.</strong></p> >- <ol> >- <li>only search fields mapped with biblios can be weighted</li> >- <li>search will boost/increase weighted field(s) relevancy</li> >- </ol> >- </div> > [% IF errors %] > <div class="dialog alert"> > Changes have not been applied. Please check the following values: >@@ -90,12 +81,25 @@ a.add, a.delete { > <input type="hidden" name="op" value="reset_confirmed" /> > <button type="submit" class="approve"><i class="fa fa-fw fa-check"></i> Yes, reset mappings</button> > </form> >- <br> >+ > <form method="post"> > <button type="submit" class="deny"><i class="fa fa-fw fa-remove"></i> No, do not reset mappings</button> > </form> > </div> > [% END %] >+ >+ <div class="note"> >+ <i class="fa fa-exclamation"></i> >+ <strong>Warning:</strong> Any changes to the configuration will only take effect after a full reindex. Until then searching may not work correctly. >+ >+ <p><strong>Weight:</strong> define weight as a positive number. Higher numbers indicate increased relevancy. >+ <strong>Note that fields weighting works only for simple search.</strong></p> >+ <ol> >+ <li>Only search fields mapped with biblios can be weighted</li> >+ <li>Search will boost/increase weighted field(s) relevancy</li> >+ </ol> >+ </div> >+ > <form method="post"> > <div id="tabs" class="toptabs" style="clear:both"> > <ul> >@@ -450,7 +454,7 @@ a.add, a.delete { > </div> > <p> > <button class="btn btn-default" type="submit" name="op" value="edit"><i class="fa fa-hdd-o" aria-hidden="true"></i> Save</button> >- <button class="btn btn-default" type="submit" name="op" value="reset_confirm"><i class="fa fa-refresh" aria-hidden="true"></i> Reset Mappings</button> >+ <button class="btn btn-default" type="submit" name="op" value="reset_confirm"><i class="fa fa-refresh" aria-hidden="true"></i> Reset mappings</button> > </p> > </form> > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27695
:
116842
|
117282
|
117569
|
119428
|
119550
|
119551