Attachment 116939 Details for Bug 26274 – Bug 26274: (QA follow-up) Fix the order of summary groups

[patch] Bug 26274: (QA follow-up) Fix the order of summary groups

Bug-26274-QA-follow-up-Fix-the-order-of-summary-gr.patch (text/plain), 1.34 KB, created by Martin Renvoize (ashimema) on 2021-02-17 15:02:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-02-17 15:02:41 UTC

Size: 1.34 KB

patch

obsolete

>From 4822bb7a7c69c1cab325afe25ebae7bf5ba13ef0 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 17 Feb 2021 15:00:15 +0000
>Subject: [PATCH] Bug 26274: (QA follow-up) Fix the order of summary groups
>
>The grouped income/outgoing summaries were not being explicitly
>ordered and it appears the default ordering for MySQL 8 is different to
>that of MariaDB and previous versions of MySQL and as such was causing
>test failures for that version. This patch adds an explicit sort on the
>'description' for each debit_type and credit_type grouping.
>---
> Koha/Cash/Register/Cashup.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/Koha/Cash/Register/Cashup.pm b/Koha/Cash/Register/Cashup.pm
>index a7e071afae..d3047036a4 100644
>--- a/Koha/Cash/Register/Cashup.pm
>+++ b/Koha/Cash/Register/Cashup.pm
>@@ -110,6 +110,7 @@ sub summary {
>                 'debit_type_code.description'
>             ],
>             'as' => [ 'total', 'debit_type_code', 'debit_description' ],
>+            order_by => { '-asc' => 'debit_type_code.description' },
>         }
>     );
> 
>@@ -130,6 +131,7 @@ sub summary {
>                 'credit_type_code.description'
>             ],
>             'as' => [ 'total', 'credit_type_code', 'credit_description' ],
>+            order_by => { '-asc' => 'credit_type_code.description' },
>         }
>     );
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26274: 115803 | 115804 | 115991 | 115992 | 116136 | 116137 | 116142 | 116143 | 116145 | 116146 | 116174 | 116175 | 116324 | 116325 | 116326 | 116327 | 116939