Bugzilla – Attachment 116974 Details for
Bug 27608
Correct 'accepted by' inconsistency in suggestion.tt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27608: [20.05] Corrects 'accepted by' inconsistency in suggestion.tt
Bug-27608-2005-Corrects-accepted-by-inconsistency-.patch (text/plain), 2.76 KB, created by
Jonathan Druart
on 2021-02-18 10:18:43 UTC
(
hide
)
Description:
Bug 27608: [20.05] Corrects 'accepted by' inconsistency in suggestion.tt
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-02-18 10:18:43 UTC
Size:
2.76 KB
patch
obsolete
>From c1c8387bed3cb1270ae21a8f828bbff9837900d1 Mon Sep 17 00:00:00 2001 >From: Blou <blou@inlibro.com> >Date: Wed, 3 Feb 2021 11:46:33 -0500 >Subject: [PATCH] Bug 27608: [20.05] Corrects 'accepted by' inconsistency in > suggestion.tt > >When looking at an accepted suggestion in suggestion.pl, under 'Suggestion management', the displayed cardnumber in parenthesis is the wrong one. It displays the "suggestedby"'s cardnumber instead of the acceptedby. > >Test: >- create a suggestion in OPAC or staff client with user A. >- In staff client, go to accept it with User B. >- Click Edit >- Under section "Suggestion management", you have a "Accepted on". >- In the By column, the cardnumber in parenthsis is not the B one. >- Apply patch, refresh. > >Looking at the code patch is self-explanatory. > >Sponsored-by: Collecto > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >JD Amended patch: Add sponsor line >--- > .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index 845df295f1..74847145ae 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -397,7 +397,7 @@ > <tr> > <th><label for="accepteddate">Accepted on:</label> </th> > <td><input type="text" id="accepteddate" name="accepteddate" class="datepicker" size="10" maxlength="10" value="[% accepteddate | $KohaDates %]" />[% INCLUDE 'date-format.inc' %]</td> >- <td><input type="hidden" id="acceptedby" name="acceptedby" value="[% acceptedby | html %]"/>[% IF ( acceptedby_patron.borrowernumber ) %]<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% acceptedby_patron.borrowernumber | uri %]">[% acceptedby_patron.surname | html %], [% acceptedby_patron.firstname | html %] ([% suggestedby_patron.cardnumber | html %])</a> [% Branches.GetName( acceptedby_patron.branchcode ) | html %] ([% acceptedby_patron.category.description | html %])[% END %]</td> >+ <td><input type="hidden" id="acceptedby" name="acceptedby" value="[% acceptedby | html %]"/>[% IF ( acceptedby_patron.borrowernumber ) %]<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% acceptedby_patron.borrowernumber | uri %]">[% acceptedby_patron.surname | html %], [% acceptedby_patron.firstname | html %] ([% acceptedby_patron.cardnumber | html %])</a> [% Branches.GetName( acceptedby_patron.branchcode ) | html %] ([% acceptedby_patron.category.description | html %])[% END %]</td> > <td></td> > </tr> > <tr> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27608
:
116288
|
116341
|
116450
|
116499
| 116974