Bugzilla – Attachment 117021 Details for
Bug 27058
Cannot place hold to ordered item when on shelf holds are not allowed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27058: Remove confusing and unnecessary $biblionumber1 variable
Bug-27058-Remove-confusing-and-unnecessary-biblion.patch (text/plain), 3.81 KB, created by
Joonas Kylmälä
on 2021-02-19 07:53:56 UTC
(
hide
)
Description:
Bug 27058: Remove confusing and unnecessary $biblionumber1 variable
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2021-02-19 07:53:56 UTC
Size:
3.81 KB
patch
obsolete
>From fcc2c124219efb41f70e1fcb2fe0f6fd400b6c7a Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi> >Date: Fri, 19 Feb 2021 09:49:51 +0200 >Subject: [PATCH] Bug 27058: Remove confusing and unnecessary $biblionumber1 > variable > >The code is much more understandable now because with $biblio2 and >$biblionumber1 variables use to point to the same biblio one might >have thought $biblionumber1 points to $biblio1 which in this case is >not true. Let's just drop the extra variable because the object >notation of accessing is just as simple. > >To test: > 1) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t => passes >--- > t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > >diff --git a/t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t b/t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t >index eb7284bf84..13600eb871 100755 >--- a/t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t >+++ b/t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t >@@ -326,16 +326,15 @@ subtest 'Check holds availability with different item types' => sub { > # (Bug 24683): > > my $biblio2 = $builder->build_sample_biblio( { itemtype => $itemtype } ); >- my $biblionumber1 = $biblio2->biblionumber; > my $item4 = $builder->build_sample_item( >- { biblionumber => $biblionumber1, >+ { biblionumber => $biblio2->biblionumber, > itype => $itemtype, > homebranch => $library_A, > holdingbranch => $library_A > } > ); > my $item5 = $builder->build_sample_item( >- { biblionumber => $biblionumber1, >+ { biblionumber => $biblio2->biblionumber, > itype => $itemtype2, > homebranch => $library_A, > holdingbranch => $library_A >@@ -371,7 +370,7 @@ subtest 'Check holds availability with different item types' => sub { > } > ); > >- $is = ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblionumber1, patron => $patron1 } ); >+ $is = ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblio2->biblionumber, patron => $patron1 } ); > is( $is, 1, "Items availability: 2 items, one allowed by smart rule but not checked out, another one not allowed to be held by smart rule" ); > > $is = IsAvailableForItemLevelRequest( $item4, $patron1 ); >@@ -382,7 +381,7 @@ subtest 'Check holds availability with different item types' => sub { > > AddIssue( $patron2->unblessed, $item4->barcode ); > >- $is = ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblionumber1, patron => $patron1 } ); >+ $is = ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblio2->biblionumber, patron => $patron1 } ); > is( $is, 0, "Items availability: 2 items, one allowed by smart rule and checked out, another one not allowed to be held by smart rule" ); > > $is = IsAvailableForItemLevelRequest( $item4, $patron1 ); >@@ -397,9 +396,8 @@ subtest 'Check item checkout availability with ordered item' => sub { > plan tests => 1; > > my $biblio2 = $builder->build_sample_biblio( { itemtype => $itemtype } ); >- my $biblionumber1 = $biblio2->biblionumber; > my $item1 = $builder->build_sample_item( >- { biblionumber => $biblionumber1, >+ { biblionumber => $biblio2->biblionumber, > itype => $itemtype2, > homebranch => $library_A, > holdingbranch => $library_A, >@@ -422,7 +420,7 @@ subtest 'Check item checkout availability with ordered item' => sub { > } > ); > >- $is = ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblionumber1, patron => $patron1 } ); >+ $is = ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblio2->biblionumber, patron => $patron1 } ); > is( $is, 0, "Ordered item cannot be checked out" ); > }; > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27058
:
113820
|
113821
|
113822
|
113824
|
113825
|
114203
|
114204
|
114210
|
114211
|
117021
|
117780
|
117781
|
117782
|
117855
|
117864
|
117865