Bugzilla – Attachment 117102 Details for
Bug 27732
JavaScript error on place hold page in the staff interface
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27732: JavaScript error on place hold page in the staff interface
Bug-27732-JavaScript-error-on-place-hold-page-in-t.patch (text/plain), 2.07 KB, created by
David Nind
on 2021-02-19 22:17:11 UTC
(
hide
)
Description:
Bug 27732: JavaScript error on place hold page in the staff interface
Filename:
MIME Type:
Creator:
David Nind
Created:
2021-02-19 22:17:11 UTC
Size:
2.07 KB
patch
obsolete
>From 7ee8cfc04bbe1cf54a26028a12108c7ef7ec1aae Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 19 Feb 2021 14:27:08 +0000 >Subject: [PATCH] Bug 27732: JavaScript error on place hold page in the staff > interface > >This patch moves the "$.fn.select2.defaults" definition from the top of >the page to the bottom so that jQuery will be loaded first. > >The patch also changes the "dropdownAutoWidth" default so that the >dropdown is sized correctly for its contents, regardless of the width of >the initial <select>. > >To test, apply the patch and place a hold in the staff interface for a >title which already has existing holds. > >- On the "Place a hold" page, before selecting a patron, you should see > a table of exising holds. Test the "Pickup library" dropdown. It should > work correctly. >- The width of the dropdown should accommodate its contents without > forcing any library name to wrap. >- There should be no errors in the browser console. > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index dc85eff568..09e8e66188 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -20,9 +20,7 @@ > </head> > > <body id="circ_request" class="catalog"> >-<script> >- $.fn.select2.defaults.set("width", "100%" ); >-</script> >+ > [% INCLUDE 'header.inc' %] > [% INCLUDE 'circ-search.inc' %] > >@@ -1015,6 +1013,8 @@ > cannotBeTransferred: _("Cannot be transferred to pickup library") > } > columns_settings_borrowers_table = [% TablesSettings.GetColumns( 'circ', 'circulation', 'table_borrowers', 'json' ) | $raw %]; >+ $.fn.select2.defaults.set("width", "100%" ); >+ $.fn.select2.defaults.set("dropdownAutoWidth", true ); > > $(document).ready(function() { > $('#cancellation-reason-fieldset').hide(); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27732
:
117086
|
117102
|
117157