Bugzilla – Attachment 117140 Details for
Bug 27071
Hold pickup library match not enforced correctly on intranet when using hold groups
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27071: Fix Hold pickup library when using hold groups
Bug-27071-Fix-Hold-pickup-library-when-using-hold-.patch (text/plain), 969 bytes, created by
Tomás Cohen Arazi (tcohen)
on 2021-02-22 12:33:56 UTC
(
hide
)
Description:
Bug 27071: Fix Hold pickup library when using hold groups
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2021-02-22 12:33:56 UTC
Size:
969 bytes
patch
obsolete
>From aae038caaf7af24ad3860531fe1725635271b3b5 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 23 Nov 2020 15:49:35 +0100 >Subject: [PATCH] Bug 27071: Fix Hold pickup library when using hold groups > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/Library.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/Koha/Library.pm b/Koha/Library.pm >index fc2f4f522e8..62ec4ec49c5 100644 >--- a/Koha/Library.pm >+++ b/Koha/Library.pm >@@ -247,10 +247,10 @@ sub validate_hold_sibling { > > foreach (@hold_libraries) { > my $hold_library = $_; >- my $is_valid = 1; >+ my $is_valid = 0; > foreach my $key (keys %$params) { >- unless($hold_library->$key eq $params->{$key}) { >- $is_valid=0; >+ if ($hold_library->$key eq $params->{$key}) { >+ $is_valid=1; > last; > } > } >-- >2.30.1
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=117140">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27071
:
113928
|
113929
|
113963
|
116599
|
116600
|
116601
|
116602
|
116603
|
117140
|
117141
|
117142
|
117143
|
117144
|
117145
|
117184
|
117185
|
117186
|
117187
|
117188
|
117189
|
117204
|
117205
|
117206
|
117207
|
117208
|
117209