Bugzilla – Attachment 117160 Details for
Bug 27731
Place hold link for individual OPAC search result broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27731: Remove hold class from individual OPAC search result hold link
Bug-27731-Remove-hold-class-from-individual-OPAC-s.patch (text/plain), 3.41 KB, created by
Martin Renvoize (ashimema)
on 2021-02-22 16:04:13 UTC
(
hide
)
Description:
Bug 27731: Remove hold class from individual OPAC search result hold link
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-02-22 16:04:13 UTC
Size:
3.41 KB
patch
obsolete
>From 70e864911fc667a5aaabd575b0a929db0a9b10ae Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 19 Feb 2021 11:46:16 +0000 >Subject: [PATCH] Bug 27731: Remove hold class from individual OPAC search > result hold link > >This patch removes the "hold" class from the "Place hold" link >associated with each search result in the OPAC. The class isn't required >for any functionality or style and it unintentionally triggers the "hold >multiple" JS function which requires that a checkbox be checked. > >To test, apply the patch and log into the OPAC as a user who can place >holds. > >- Perform a catalog search which will return multiple results. >- Click the "Place hold" link under any search result. >- You should be taken to the hold confirmation page. >- On the search results page, confirm that the "Place hold" link at the > top of the search results still works to place multiple holds at once. > >Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../opac-tmpl/bootstrap/en/includes/title-actions-menu.inc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc >index 0b58145c49..55ff553370 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc >@@ -4,14 +4,14 @@ > [% IF Koha.Preference( 'opacuserlogin' ) == 1 %] > [% IF ( shelf AND op == 'view' ) # Lists view has more granular checking of hold availability %] > [% IF ( items.allow_onshelf_holds ) %] >- <span class="actions"><a class="btn btn-link btn-sm hold" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]"><i class="fa fa-fw fa-bookmark" aria-hidden="true"></i> Place hold</a></span> >+ <span class="actions"><a class="btn btn-link btn-sm" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]"><i class="fa fa-fw fa-bookmark" aria-hidden="true"></i> Place hold</a></span> > [% ELSE %] > [% IF ( items.itemsissued ) %] >- <span class="actions"><a class="btn btn-link btn-sm hold" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]"><i class="fa fa-fw fa-bookmark" aria-hidden="true"></i> Place hold</a></span> >+ <span class="actions"><a class="btn btn-link btn-sm" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]"><i class="fa fa-fw fa-bookmark" aria-hidden="true"></i> Place hold</a></span> > [% END %] > [% END %] > [% ELSE %] >- <span class="actions"><a class="btn btn-link btn-sm hold" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]"><i class="fa fa-fw fa-bookmark" aria-hidden="true"></i> Place hold</a></span> >+ <span class="actions"><a class="btn btn-link btn-sm" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]"><i class="fa fa-fw fa-bookmark" aria-hidden="true"></i> Place hold</a></span> > [% END %] > [% END # / IF opacuserlogin %] > [% END # / UNLESS items.norequests %] >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27731
:
117061
|
117092
| 117160