Attachment 117167 Details for Bug 27332 – Bug 27332: Use the branchcode from the subscription when renewing

[patch] Bug 27332: Use the branchcode from the subscription when renewing

Bug-27332-Use-the-branchcode-from-the-subscription.patch (text/plain), 1.95 KB, created by Martin Renvoize (ashimema) on 2021-02-22 16:18:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-02-22 16:18:27 UTC

Size: 1.95 KB

patch

obsolete

>From 618cbf4d41c04bcfb686c7fc7f1e831cdfe12806 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 5 Jan 2021 08:10:33 +0100
>Subject: [PATCH] Bug 27332: Use the branchcode from the subscription when
> renewing
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../prog/en/modules/serials/subscription-renew.tt            | 5 ++---
> serials/subscription-renew.pl                                | 3 ---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt
>index 13222ad04f..614a21afc4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt
>@@ -1,3 +1,4 @@
>+[% USE Branches %]
> [% SET footerjs = 1 %]
> [% INCLUDE 'doc-head-open.inc' %]
> [% IF subscription %]
>@@ -64,9 +65,7 @@
>             <option value="">None</option>
>         [% END %]
>         [% IF CAN_user_serials_superserials %]
>-            [% FOREACH library IN libraries %]
>-                <option value="[% library.branchcode | html %]"> [% library.branchname | html %] </option>
>-            [% END %]
>+            [% PROCESS options_for_libraries libraries => Branches.all(selected => subscription.branchcode) %]
>         [% END %]
>     </select> (select a library)
>     </li>
>diff --git a/serials/subscription-renew.pl b/serials/subscription-renew.pl
>index 94f0f506ba..80727da866 100755
>--- a/serials/subscription-renew.pl
>+++ b/serials/subscription-renew.pl
>@@ -129,11 +129,8 @@ if ( $op eq "renew" ) {
>     );
> }
> 
>-my $libraries = Koha::Libraries->search( {}, { order_by => ['branchcode'] }, );
>-
> $template->param(
>     op => $op,
>-    libraries      => $libraries,
> );
> 
> output_html_with_http_headers $query, $cookie, $template->output;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27332: 114834 | 114854 | 116479 | 116480 | 116481 | 117167 | 117168