Attachment 117168 Details for Bug 27332 – Bug 27332: Hide branchcode and note is RenewSerialAddsSuggestion if off

[patch] Bug 27332: Hide branchcode and note is RenewSerialAddsSuggestion if off

Bug-27332-Hide-branchcode-and-note-is-RenewSerialA.patch (text/plain), 2.68 KB, created by Martin Renvoize (ashimema) on 2021-02-22 16:18:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-02-22 16:18:31 UTC

Size: 2.68 KB

patch

obsolete

>From d67405442ecf41312ebb5c320a9114a53077a47c Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 5 Jan 2021 09:54:54 +0100
>Subject: [PATCH] Bug 27332: Hide branchcode and note is
> RenewSerialAddsSuggestion if off
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../en/modules/serials/subscription-renew.tt  | 34 ++++++++++++-------
> 1 file changed, 21 insertions(+), 13 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt
>index 614a21afc4..f3f8c16d09 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt
>@@ -1,3 +1,4 @@
>+[% USE Koha %]
> [% USE Branches %]
> [% SET footerjs = 1 %]
> [% INCLUDE 'doc-head-open.inc' %]
>@@ -59,20 +60,27 @@
>     <input type="hidden" name="issuelengthcount">
>     </li>
> 
>-    <li><label for="branchcode">Library:</label>
>-    <select name="branchcode" id="branchcode" style="width: 20em;">
>-        [% UNLESS ( Independentbranches ) %]
>-            <option value="">None</option>
>-        [% END %]
>-        [% IF CAN_user_serials_superserials %]
>-            [% PROCESS options_for_libraries libraries => Branches.all(selected => subscription.branchcode) %]
>-        [% END %]
>-    </select> (select a library)
>-    </li>
>+    [% IF Koha.Preference('RenewSerialAddsSuggestion') %]
>+        <li>
>+            <label for="branchcode">Library:</label>
>+            <select name="branchcode" id="branchcode" style="width: 20em;">
>+                [% UNLESS ( Independentbranches ) %]
>+                    <option value="">None</option>
>+                [% END %]
>+                [% IF CAN_user_serials_superserials %]
>+                    [% PROCESS options_for_libraries libraries => Branches.all(selected => subscription.branchcode) %]
>+                [% END %]
>+            </select> (select a library)
>+        </li>
> 
>-    <li><label for="note">Note for the librarian that will manage your renewal request: </label>
>-		<textarea name="note" id="note" rows="5" cols="50"></textarea></li></ol></fieldset>
>-		<fieldset class="action"><input type="submit" value="Submit" class="button" /></fieldset>
>+        <li>
>+            <label for="note">Note for the librarian that will manage your renewal request: </label>
>+            <textarea name="note" id="note" rows="5" cols="50"></textarea>
>+        </li>
>+    [% END %]
>+</ol>
>+</fieldset>
>+<fieldset class="action"><input type="submit" value="Submit" class="button" /></fieldset>
> </form>
> [% END %]
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27332: 114834 | 114854 | 116479 | 116480 | 116481 | 117167 | 117168