Attachment 117254 Details for Bug 14233 – Bug 14233: Allow comparing notice changes

[patch] Bug 14233: Allow comparing notice changes

Bug-14233-Allow-comparing-notice-changes.patch (text/plain), 2.57 KB, created by Martin Renvoize (ashimema) on 2021-02-24 13:01:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-02-24 13:01:55 UTC

Size: 2.57 KB

patch

obsolete

>From e6fbd42129dbd62204695046e6033955fd5dde09 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 10 Feb 2021 14:00:36 +0000
>Subject: [PATCH] Bug 14233: Allow comparing notice changes
>
>This patch adds the 'compare' option to the Notices logs.
>
>Test plan
>1/ Make some changes to at least two different notices to trigger logs
>2/ Go to the 'Log viewer' from 'Tools' and filter on 'Notices'
>3/ Note, you can now see the 'Compare' checkbox option for these logs
>4/ Select the checkbox on one of the notices and note that the results
>are now filtered by that specific notice.
>5/ Select a second checkbox to expose the option to 'View comparison'
>6/ Click 'View comparison' to see the 'Diff view' of the two notices.
>7/ Signoff
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
>index fe25a98dfc..43ccb5aab9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
>@@ -340,6 +340,11 @@
>                                                 <div class="compare_info" id="compare_info[% loopro.action_id | html %]">
>                                                     <label><input type="checkbox" name="diff" id="action_id[% loopro.action_id | html %]" data-actionid="[% loopro.action_id | html %]" data-filter="[% FOREACH info IN loopro.info.split(' \| ') %][% IF loop.first %][% info | html %][% END %][% END %]" class="compare" /> Compare</label>
>                                                 </div>
>+                                            [% ELSIF loopro.module == "NOTICES" %]
>+                                                <div class="loginfo" id="loginfo[% loopro.action_id | html %]">[% loopro.info | trim | html %]</div>
>+                                                <div class="compare_info" id="compare_info[% loopro.action_id | html %]">
>+                                                    <label><input type="checkbox" name="diff" id="action_id[% loopro.action_id | html %]" data-actionid="[% loopro.action_id | html %]" data-filter="[% loopro.notice.title | html %]" class="compare" /> Compare</label>
>+                                                </div>
>                                             [% ELSE %]
>                                                 <div class="loginfo" id="loginfo[% loopro.action_id | html %]">
>                                                     [% loopro.info | html %]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 14233: 116649 | 116650 | 116651 | 116660 | 116661 | 116662 | 116668 | 116671 | 116672 | 116673 | 116674 | 116713 | 116760 | 116761 | 117251 | 117252 | 117253 | 117254 | 117255 | 117256 | 117257 | 117258 | 117259 | 117294 | 117295 | 117296 | 117297 | 117298 | 117299 | 117300 | 117301 | 117302 | 117303 | 117304 | 117311 | 117312 | 117313 | 117314 | 117315 | 117316 | 117317 | 117318 | 117319 | 117320 | 117321 | 117345 | 118132 | 118133 | 118134 | 118135 | 118136 | 118137 | 118138 | 118139 | 118140 | 118141 | 118142 | 118143 | 118155 | 118156 | 118157 | 118158 | 118159 | 118160 | 118161 | 118162 | 118163 | 118164 | 118165 | 118166 | 118167 | 118323 | 119291 | 119292 | 119293 | 119294 | 119312 | 119313 | 119314 | 119315 | 119359 | 119360 | 119361 | 119362 | 119510