Attachment 117281 Details for Bug 27749 – Bug 27749: Phase out jquery.cookie.js: Search to hold

[patch] Bug 27749: Phase out jquery.cookie.js: Search to hold

Bug-27749-Phase-out-jquerycookiejs-Search-to-hold.patch (text/plain), 3.37 KB, created by David Nind on 2021-02-24 20:11:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2021-02-24 20:11:31 UTC

Size: 3.37 KB

patch

obsolete

>From 2bf2870c1d56eb60806812547557b3c76b5b5f77 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 22 Feb 2021 15:31:41 +0000
>Subject: [PATCH] Bug 27749: Phase out jquery.cookie.js: Search to hold
>
>This patch modifies the "search to hold" process for patrons and clubs
>so that the newer jquery-cookie plugin is used instead of jquery.cookie.
>
>To test, apply the patch and locate a patron in the staff interface.
>
> - From the patron checkout or details page, click "Search to hold" in
>   the toolbar."
> - Perform a catalog search which will return results.
> - On the search results page you should see a "Place hold for..." link
>   with the correct patron information under each result.
> - In the toolbar above the search results you should see a "Place hold"
>   button with a dropdown menu which also references the patron you
>   selected.
> - Test that each option works to place a hold for your patron.
> - Test that the "Forget..." menu option works to remove "place hold
>   for" options.
> - Test that your "Place hold for" option is also remembered on the
>   bibliographic detail page.
>
>To test the changes to Patron Clubs:
>
> - If necessary, create a patron club:
>   https://koha-community.org/manual/20.11/en/html/tools.html?highlight=club#patron-clubs
> - Add one or more patrons to the club:
>   https://koha-community.org/manual/20.11/en/html/tools.html?highlight=club#enrolling-a-patron-in-a-club-from-the-staff-client
> - From the patron clubs page, choose "Search to hold" from the club's
>   "Actions" menu.
> - Perform the same tests above.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt | 2 +-
> koha-tmpl/intranet-tmpl/prog/js/members-menu.js        | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt
>index f7db215b35..6427446458 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt
>@@ -220,7 +220,7 @@
>         function SearchToHold(club_id) {
>             var date = new Date();
>             date.setTime(date.getTime() + (10 * 60 * 1000));
>-            $.cookie("holdforclub", club_id, { path: "/", expires: date });
>+            Cookies.set("holdforclub", club_id, { path: "/", expires: date });
>             location.href="/cgi-bin/koha/catalogue/search.pl";
>         }
>     </script>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/members-menu.js b/koha-tmpl/intranet-tmpl/prog/js/members-menu.js
>index 9db8b24bbe..e17ee3cf72 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/members-menu.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/members-menu.js
>@@ -1,4 +1,4 @@
>-/* global borrowernumber advsearch dateformat __ CAN_user_borrowers_edit_borrowers number_of_adult_categories destination Sticky */
>+/* global borrowernumber advsearch dateformat __ CAN_user_borrowers_edit_borrowers number_of_adult_categories destination Sticky Cookies */
> 
> $(document).ready(function(){
> 
>@@ -153,6 +153,6 @@ function printx_window(print_type) {
> function searchToHold(){
>     var date = new Date();
>     date.setTime(date.getTime() + (10 * 60 * 1000));
>-    $.cookie("holdfor", borrowernumber, { path: "/", expires: date });
>+    Cookies.set("holdfor", borrowernumber, { path: "/", expires: date });
>     location.href="/cgi-bin/koha/catalogue/search.pl";
> }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27749: 117172 | 117281 | 119164