Bugzilla – Attachment 117293 Details for
Bug 27718
Holds to Pull list doesn't respect holdallowed circulation rule anymore
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27718: (follow-up) add missing return
Bug-27718-follow-up-add-missing-return.patch (text/plain), 1.16 KB, created by
Joonas Kylmälä
on 2021-02-25 08:56:51 UTC
(
hide
)
Description:
Bug 27718: (follow-up) add missing return
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2021-02-25 08:56:51 UTC
Size:
1.16 KB
patch
obsolete
>From 72bf01ef127448b3e1fe8251cae18eb8febfbb8e Mon Sep 17 00:00:00 2001 >From: Andrew Nugged <nugged@gmail.com> >Date: Wed, 24 Feb 2021 11:45:07 +0200 >Subject: [PATCH] Bug 27718: (follow-up) add missing return >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Missing return doesn't allowed for "wantarray" state to DBIXc so sub returned scalar in any context. > >Also blank line to match with coding style removed. > >Signed-off-by: Andrew Nugged <nugged@gmail.com> >Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> >--- > Koha/Holds.pm | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/Koha/Holds.pm b/Koha/Holds.pm >index 61351a1efd..e63eadba70 100644 >--- a/Koha/Holds.pm >+++ b/Koha/Holds.pm >@@ -140,7 +140,7 @@ sub get_items_that_can_fill { > } > )->get_column('itemtype'); > >- my $items = Koha::Items->search( >+ return Koha::Items->search( > { > biblionumber => { in => \@biblionumbers }, > itemlost => 0, >@@ -151,7 +151,6 @@ sub get_items_that_can_fill { > itype => { -not_in => \@hold_not_allowed_itypes }, > } > ); >- > } > > =head3 type >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27718
:
116940
|
116941
|
117198
|
117199
|
117234
|
117235
|
117241
|
117242
|
117243
|
117291
|
117292
| 117293