Attachment 117324 Details for Bug 27792 – Bug 27792: Improve jEditable configuration for point of sale fields

[patch] Bug 27792: Improve jEditable configuration for point of sale fields

Bug-27792-Improve-jEditable-configuration-for-poin.patch (text/plain), 2.76 KB, created by Martin Renvoize (ashimema) on 2021-02-25 13:56:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-02-25 13:56:55 UTC

Size: 2.76 KB

patch

obsolete

>From 2132edea8210378cb9661e520b27ebd2442d32a3 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 25 Feb 2021 12:15:02 +0000
>Subject: [PATCH] Bug 27792: Improve jEditable configuration for point of sale
> fields
>
>This patch alters the configuration of the "cost" and "quantity"
>editable fields in the "This sale" table on the Point of Sale page:
>
> - Reduce field with to reduce jumpy table re-draws.
> - Replace "numeric" input type with "text"
> - Add pattern attribute for enforcing currency/number entry
>
>To test you must have EnablePointOfSale and UseCashRegisters enabled and
>configured.
>
> - Apply the patch and go to the Point of Sale page.
> - Add some items for purchase.
> - In the "This sale" table, click the values in the "cost" and
>   "quantity" columns and try editing their values.
> - The form field which appears should not fill the width of the table
>   column.
> - The fields should enforce the correct input: Currency for the "cost"
>   column, digits for the "quantity" column.
> - The fields should update when you click out of them and the correct
>   values should appear in the "Collect payment" area.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../intranet-tmpl/prog/en/modules/pos/pay.tt     | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
>index 4d35b60ff7..1326eba204 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
>@@ -306,20 +306,20 @@
>                     local.fnUpdate( value, aPos[0], aPos[1], true, false );
>                     return value;
>                 },{
>-                    type    : 'number',
>-                    step    : '0.01',
>-                    min     : '0',
>-                    onblur  : 'submit'
>+                    type    : 'text',
>+                    pattern : "^\d+(\.\d{2})?$",
>+                    onblur  : 'submit',
>+                    width   : "8em"
>                 });
>                 local.$('.editable_int').editable( function(value, settings) {
>                     var aPos = local.fnGetPosition( this );
>                     local.fnUpdate( value, aPos[0], aPos[1], true, false );
>                     return value;
>                 },{
>-                    type    : 'number',
>-                    step    : '1',
>-                    min     : '0',
>-                    onblur  : 'submit'
>+                    type    : 'text',
>+                    pattern : "[0-9]*",
>+                    onblur  : 'submit',
>+                    width   : "4em"
>                 });
>             },
>             "fnRowCallback": function( nRow, aData, iDisplayIndex, iDisplayIndexFull ) {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27792: 117306 | 117324 | 117325 | 117412 | 117413