Attachment 117332 Details for Bug 27790 – Bug 27790: separate earliest hold date into two different columns

[patch] Bug 27790: separate earliest hold date into two different columns

Bug-27790-separate-earliest-hold-date-into-two-dif.patch (text/plain), 2.83 KB, created by Owen Leonard on 2021-02-25 14:52:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2021-02-25 14:52:45 UTC

Size: 2.83 KB

patch

obsolete

>From 935be575de91cecbf79abaf8d3ad10c278412289 Mon Sep 17 00:00:00 2001
>From: Petro Vashchuk <stalkernoid@gmail.com>
>Date: Thu, 25 Feb 2021 12:28:17 +0200
>Subject: [PATCH] Bug 27790: separate earliest hold date into two different
> columns
>
>Currently "Earliest hold date" and "Pickup place" are displayed
>in one single column, but to make filtering possible it is necessary
>to split those fields into separate ones.
>This patch does exactly that and adds sorting list drop down feature to
>the "Pickup place" column.
>
>To reproduce:
>    1) Make a few holds and head over to "Circulations->Holds to pull".
>    2) Ensure that pickup place and earliest hold date are
>in the same column "Earliest hold date"
>    3) Apply the patch.
>    4) Check "Circulations->Holds to pull list" again, this time
>booking date and pickup place should have their own columns.
>Ensure that filtering by "pickup location" works fine.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> .../intranet-tmpl/prog/en/modules/circ/pendingreserves.tt   | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt
>index 5909cfdbac..e8f60429ec 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt
>@@ -64,6 +64,7 @@
>         <th class="string-sort">Available item types</th>
>         <th class="string-sort">Available locations</th>
>         <th class="title-string">Earliest hold date</th>
>+        <th class="string-sort">Pickup location</th>
>         <th>Action</th>
>         </tr>
>     </thead>
>@@ -157,7 +158,10 @@
>             </ul>
>         </td>
>         <td>
>-            <span title="[% hold.reservedate | html %]">[% hold.reservedate | $KohaDates %] in [% Branches.GetName ( hold.branchcode ) | html %]</span>
>+            <span title="[% hold.reservedate | html %]">[% hold.reservedate | $KohaDates %]</span>
>+        </td>
>+        <td>
>+            [% Branches.GetName ( hold.branchcode ) | html %]
>         </td>
>         <td>
>             <form name="cancelReserve" action="/cgi-bin/koha/circ/pendingreserves.pl" method="post">
>@@ -219,6 +223,7 @@
>         <td id="itemtype-filter"></td>
>         <td id="locationfilter"></td>
>         <td></td>
>+        <td id="pickup-location"></td>
>         <td></td>
>         </tr>
>     </tfoot>
>@@ -326,6 +331,12 @@
>                   holdst.fnFilter( $(this).val(), 11 );
>               });
>           });
>+          $("#pickup-location").each( function () {
>+              $(this).html( createSelect( holdst.fnGetColumnData(13) ) );
>+              $('select', this).change( function () {
>+                  holdst.fnFilter( $(this).val(), 13 );
>+              });
>+          });
>         });
>     </script>
> [% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27790: 117305 | 117332 | 120123 | 120124 | 120229