Attachment 117366 Details for Bug 27578 – Bug 27578: Initialize searchid as blank when not populated

[patch] Bug 27578: Initialize searchid as blank when not populated

Bug-27578-Initialize-searchid-as-blank-when-not-po.patch (text/plain), 1.36 KB, created by Marcel de Rooy on 2021-02-26 08:44:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2021-02-26 08:44:29 UTC

Size: 1.36 KB

patch

obsolete

>From 011e7df1cb84e23425c8dcdf32b6c58a00a2a9b5 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 29 Jan 2021 13:47:22 +0000
>Subject: [PATCH] Bug 27578: Initialize searchid as blank when not populated
>Content-Type: text/plain; charset=utf-8
>
>This patch simply sets the searchid to a blank string if not passed in
>
>To test:
>1 - Add a new biblio and save it
>2 - Check the logs: /var/log/koha/kohadev/plack-intranet-error.log (or similar)
>3 - Note warn about uninitialized value
>4 - Apply patch
>5 - Add a new biblio
>6 - No warn
>
>Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> cataloguing/addbiblio.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl
>index a4614cc941..c378556979 100755
>--- a/cataloguing/addbiblio.pl
>+++ b/cataloguing/addbiblio.pl
>@@ -699,7 +699,7 @@ my $op            = $input->param('op') // q{};
> my $mode          = $input->param('mode');
> my $frameworkcode = $input->param('frameworkcode');
> my $redirect      = $input->param('redirect');
>-my $searchid      = $input->param('searchid');
>+my $searchid      = $input->param('searchid') // "";
> my $dbh           = C4::Context->dbh;
> my $hostbiblionumber = $input->param('hostbiblionumber');
> my $hostitemnumber = $input->param('hostitemnumber');
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27578: 116031 | 117238 | 117366