Attachment 117382 Details for Bug 27808 – Bug 27808: Mark the onloan column as dirty in AddIssue

[patch] Bug 27808: Mark the onloan column as dirty in AddIssue

Bug-27808-Mark-the-onloan-column-as-dirty-in-AddIs.patch (text/plain), 1.86 KB, created by Kyle M Hall (khall) on 2021-02-26 15:03:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2021-02-26 15:03:13 UTC

Size: 1.86 KB

patch

obsolete

>From 2a05e54741e6b45c801fb55b4445333ad69bcd1b Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 26 Feb 2021 09:56:07 -0500
>Subject: [PATCH] Bug 27808: Mark the onloan column as dirty in AddIssue
>
>If any item is currently checked out to a patron, and the item is then checked out directly to another patron without manually checking the item in first, the items.onloan column will remain NULL.
>
>This will only happen if the new checkout will be due the same day as the previous checked.
>
>This is caused by the item being returned without updating the item object from storage afterward. Even though AddIssue will call AddReturn which sets the value of onloan to NULL in the database, we are not passing in the item object by reference, so it's onloan value remains set to a date. Then we set the onloan value to the same date. Because the value does not change in the object, the column does not get marked dirty.
>
>We could update the object from storage first, but it seems more efficient to mark the column as dirty manually to avoid that otherwise unnecessary fetch.
>
>Test Plan:
>1) Apply these patches
>2) prove t/db_dependent/Circulation.t
>---
> C4/Circulation.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 5b5a0d2c23..838d0259cb 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -1565,6 +1565,7 @@ sub AddIssue {
>             $item_object->holdingbranch(C4::Context->userenv->{'branch'});
>             $item_object->itemlost(0);
>             $item_object->onloan($datedue->ymd());
>+            $item_object->make_column_dirty('onloan'); # Force write onloan so we don't need to fetch from db
>             $item_object->datelastborrowed( dt_from_string()->ymd() );
>             $item_object->datelastseen( dt_from_string()->ymd() );
>             $item_object->store({log_action => 0});
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 27808: 117380 | 117381 | 117382 | 117384 | 117385 | 117386 | 117387 | 117398 | 117399 | 117400 | 117443 | 117445 | 117446 | 117454 | 117456