Attachment 1174 Details for Bug 3238 – bugfix

[patch] bugfix

0001--bug-3238-fix-the-shelf-edition-in-opac.patch (text/plain), 1.21 KB, created by Chris Cormack on 2009-05-20 15:06:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2009-05-20 15:06:00 UTC

Size: 1.21 KB

patch

obsolete

>From 1cfdd91ae5e51b3b85e8b33adbcb3d628bd678a0 Mon Sep 17 00:00:00 2001
>From: Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com>
>Date: Wed, 20 May 2009 17:00:24 +0200
>Subject: [PATCH] (bug #3238) fix the shelf edition in opac
>Content-Type: text/plain; charset="utf-8"
>
>This fix the security issue about shelf edition that allow any non-logged user to modify them.
>---
> C4/VirtualShelves.pm |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/C4/VirtualShelves.pm b/C4/VirtualShelves.pm
>index b3e5b26..9c85602 100644
>--- a/C4/VirtualShelves.pm
>+++ b/C4/VirtualShelves.pm
>@@ -476,7 +476,7 @@ sub ShelfPossibleAction {
> 	return 1 if ( $category >= 3);							# open list
>     return 1 if (($category >= 2) and
> 				defined($action) and $action eq 'view');	# public list, anybody can view
>-    return 1 if (($category >= 2) and defined($user) and ($borrower->{authflags}->{superlibrarian} || $user == 0));	# public list, superlibrarian can edit/delete
>+    return 1 if (($category >= 2) and defined($user) and ($borrower->{authflags}->{superlibrarian}));	# public list, superlibrarian can edit/delete
>     return 1 if (defined($user)  and $owner  eq $user );	# user owns this list.  Check last.
>     return 0;
> }
>-- 
>1.6.0.4
>

Actions: View | Diff | Splinter Review

Attachments on bug 3238: 1174