Attachment 117456 Details for Bug 27808 – Bug 27808: (QA follow-up) Make sure the update catches the items we want

[patch] Bug 27808: (QA follow-up) Make sure the update catches the items we want

Bug-27808-QA-follow-up-Make-sure-the-update-catche.patch (text/plain), 1.53 KB, created by Tomás Cohen Arazi (tcohen) on 2021-03-01 14:57:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2021-03-01 14:57:16 UTC

Size: 1.53 KB

patch

obsolete

>From 10d5eb529e686eb4d06fa8f3a3eb1bed922db281 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 1 Mar 2021 11:56:23 -0300
>Subject: [PATCH] Bug 27808: (QA follow-up) Make sure the update catches the
> items we want
>
>This query:
>
>SELECT *
>FROM items
>LEFT JOIN issues
>ON issues.itemnumber=items.itemnumber
>WHERE items.onloan IS NULL;
>
>returns 961 rows on the sample data, with 2 items checked out and onloan
>set to NULL.
>
>With this tweak, the query only matches the 2 checkout items with onloan
>set to NULL:
>
>SELECT *
>FROM items
>LEFT JOIN issues
>ON issues.itemnumber=items.itemnumber
>WHERE items.onloan IS NULL AND issues.issue_id IS NOT NULL;
>
>This is the query that needs to be used on the atomic update for
>filtering the items to be updated.
>
>This patch does that.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> installer/data/mysql/updatedatabase.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index 55e8ec9396b..a5fa10a4a49 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -23575,7 +23575,7 @@ if( CheckVersion( $DBversion ) ) {
>         UPDATE items
>         LEFT JOIN issues ON issues.itemnumber=items.itemnumber
>         SET items.onloan=CAST(issues.date_due AS DATE)
>-        WHERE items.onloan IS NULL
>+        WHERE items.onloan IS NULL AND issues.issue_id IS NOT NULL
>     |);
> 
>     NewVersion( $DBversion, 27808, "Adjust items.onloan if needed" );
>-- 
>2.30.1

Actions: View | Diff | Splinter Review

Attachments on bug 27808: 117380 | 117381 | 117382 | 117384 | 117385 | 117386 | 117387 | 117398 | 117399 | 117400 | 117443 | 117445 | 117446 | 117454 | 117456