Attachment 117476 Details for Bug 27680 – Bug 27680: (QA follow-up) Update test for dbic_merge_sorting

[patch] Bug 27680: (QA follow-up) Update test for dbic_merge_sorting

Bug-27680-QA-follow-up-Update-test-for-dbicmergeso.patch (text/plain), 1.09 KB, created by Martin Renvoize (ashimema) on 2021-03-02 08:58:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-03-02 08:58:29 UTC

Size: 1.09 KB

patch

obsolete

>From 9b1c313ad889c4c6df8cdf448dec99236f08013a Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Tue, 2 Mar 2021 08:56:14 +0000
>Subject: [PATCH] Bug 27680: (QA follow-up) Update test for dbic_merge_sorting
>
>The order_by handling will now always return an arrayref of ordering
>hashrefs even when only one ordering hash is present. This is
>interpreted by dbic as equivilent so I just update the test to pass
>here.
>---
> t/Koha/REST/Plugin/Query.t | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/t/Koha/REST/Plugin/Query.t b/t/Koha/REST/Plugin/Query.t
>index b504f3ba5f..e213787783 100755
>--- a/t/Koha/REST/Plugin/Query.t
>+++ b/t/Koha/REST/Plugin/Query.t
>@@ -338,7 +338,9 @@ subtest 'dbic_merge_sorting() tests' => sub {
>     $t->get_ok('/dbic_merge_sorting_single')->status_is(200)
>       ->json_is( '/a' => 'a', 'Existing values are kept (a)' )
>       ->json_is( '/b' => 'b', 'Existing values are kept (b)' )->json_is(
>-        '/order_by' => { '-desc' => 'uno' }
>+        '/order_by' => [
>+            { '-desc' => 'uno' }
>+        ]
>       );
> };
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27680: 116794 | 116795 | 116796 | 116829 | 116831 | 116832 | 116833 | 116834 | 116843 | 116844 | 116845 | 116846 | 117335 | 117336 | 117337 | 117338 | 117339 | 117340 | 117341 | 117375 | 117388 | 117389 | 117390 | 117391 | 117392 | 117393 | 117394 | 117438 | 117439 | 117440 | 117441 | 117442 | 117476