Attachment 117553 Details for Bug 27815 – Bug 27815: "Remove" in point of sale untranslatable

[patch] Bug 27815: "Remove" in point of sale untranslatable

Bug-27815-Remove-in-point-of-sale-untranslatable.patch (text/plain), 1.97 KB, created by David Nind on 2021-03-03 09:04:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2021-03-03 09:04:13 UTC

Size: 1.97 KB

patch

obsolete

>From 581931c6cde1b6bf3b229ecc756e2da84c736d6c Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 1 Mar 2021 12:24:41 +0000
>Subject: [PATCH] Bug 27815: "Remove" in point of sale untranslatable
>
>This patch modifies the Point of Sale template so that the "Remove"
>button can be translated. The string in the JavaScript block wasn't
>wrapped in the correct function.
>
>To test, apply the patch and test that the correct strings are
>translatable. In this example I'm testing fr-FR:
>
>- Update a translation:
>
>  > cd misc/translator
>  > perl translate update fr-FR
>
>- Open the corresponding .po file for the strings pulled from
>  the template: e.g. misc/translator/po/fr-FR-staff-prog.po
>- Locate strings pulled from pos/pay.tt for translation to confirm the
>  update, e.g.:
>
>  #: koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt:189
>  #, c-format
>  msgid "Remove"
>  msgstr "Enlever"
>
>- Install the updated translation:
>
>  > perl translate install fr-FR
>
>- In the staff client, go to Point of Sale.
>- Switch to the French translation and click the "Ajouter" button next
>  to one of the items for purchase.
>- In the "This sale" table, the item you added should have a
>  corresponding "Enlever" button.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
>index 23d66d9202..e3661c45e0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
>@@ -244,7 +244,7 @@
>         defaultPrice.value,
>         1,
>         null,
>-        '<button class="btn btn-default btn-xs drop" type="button"><i class="fa fa-trash"></i> Remove</button>',
>+        '<button class="btn btn-default btn-xs drop" type="button"><i class="fa fa-trash"></i> ' + _("Remove") + '</button>',
>         invoiceCode
>         ]
>       );
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27815: 117396 | 117444 | 117553 | 117734