Attachment 117555 Details for Bug 27813 – Bug 27813: Restore default order on suggestion list view

[patch] Bug 27813: Restore default order on suggestion list view

Bug-27813-Restore-default-order-on-suggestion-list.patch (text/plain), 1.54 KB, created by David Nind on 2021-03-03 09:40:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2021-03-03 09:40:25 UTC

Size: 1.54 KB

patch

obsolete

>From 8ca842c3ad5e303d1e6768d068108d823d8dbded Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 2 Mar 2021 12:22:27 +0100
>Subject: [PATCH] Bug 27813: Restore default order on suggestion list view
>
>Prior to 20.05, suggestions on /cgi-bin/koha/suggestion/suggestion.pl sorted by
>suggesteddate by default. On 20.05 and later, they're sorting by title instead.
>We should go back to the previous behavior.
>
>Test plan:
>Create some suggestions
>Edit the suggestions.suggesteddate in the DB
>List the suggestions and confirm that there are sorted by new suggested
>date first
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>index 6b1713a773..8a7e690e40 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>@@ -1270,7 +1270,7 @@
>                 [% FOREACH suggestion IN suggestions %]
>                     [% IF ( suggestion.suggestions_loop ) %]
>                         KohaTable("table_[% loop.count| html %]", {
>-                            "sorting": [[ 1, "asc" ]],
>+                            "sorting": [[ 3, "desc" ]],
>                             "autoWidth": false,
>                         }, columns_settings );
>                     [% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27813: 117505 | 117555 | 117934 | 118018 | 118019 | 118023 | 118107