Attachment 117560 Details for Bug 27703 – Bug 27703: Make ID of category select field unique

[patch] Bug 27703: Make ID of category select field unique

Bug-27703-Make-ID-of-category-select-field-unique.patch (text/plain), 2.61 KB, created by Martin Renvoize (ashimema) on 2021-03-03 10:35:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-03-03 10:35:17 UTC

Size: 2.61 KB

patch

obsolete

>From 50e7da30382748bc66ddc74d4dda583d6ab57926 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 16 Feb 2021 13:27:34 +0000
>Subject: [PATCH] Bug 27703: Make ID of category select field unique
>
>Duplicate element IDs on the authorized values page are invalid and
>cause a problem with the JavaScript intended to submit the form when the
>category select field changes.
>
>This patch changes the ID of the label and the field and makes the
>corresponding change to the JavaScript.
>
>To test, apply the patch and go to Administration -> Authorized values.
>
> - Click an authorized value category to view its contents.
> - Using mouse or keyboard, make a selection from the "Show category"
>   dropdown menu.
> - The form should submit automatically and direct you to the
>   corresponding category.
> - Validate the HTML of the page and confirm that there are no errors.
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../prog/en/modules/admin/authorised_values.tt            | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
>index 3edb239e9c..bac32901d2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
>@@ -195,8 +195,8 @@
> 
>     <form action="/cgi-bin/koha/admin/authorised_values.pl" method="get" id="category">
>         <p>
>-            <label for="searchfield">Show category: </label>
>-            <select name="searchfield" id="searchfield" size="1">
>+            <label for="category_search">Show category: </label>
>+            <select name="searchfield" id="category_search" size="1">
>                 [% FOR c IN categories %]
>                     [% IF c == searchfield %]
>                         <option value="[% c | html %]" selected="selected">[% c | html %]</option>
>@@ -205,7 +205,6 @@
>                     [% END %]
>                 [% END %]
>             </select>
>-            <input type="submit" value="Submit" />
>         </p>
>     </form>
> 
>@@ -329,8 +328,7 @@
>             $("a.delete").click(function(){
>                 return confirm(_("Are you sure you want to delete this authorized value?"));
>             });
>-            $('#category').find("input:submit").hide();
>-            $('#searchfield').change(function() {
>+            $('#category_search').change(function() {
>                 $('#category').submit();
>             });
>             $(".library_limitation").tooltip();
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27703: 116923 | 116924 | 117231 | 117560