Attachment 117594 Details for Bug 24446 – Bug 24446: Update GetTransfers Unit Test

[patch] Bug 24446: Update GetTransfers Unit Test

Bug-24446-Update-GetTransfers-Unit-Test.patch (text/plain), 1.43 KB, created by Jonathan Druart on 2021-03-03 14:32:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-03-03 14:32:04 UTC

Size: 1.43 KB

patch

obsolete

>From a3c96b6d79f1d52b32ce28cf92d25ca712b89856 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 7 Oct 2020 14:10:46 +0100
>Subject: [PATCH] Bug 24446: Update GetTransfers Unit Test
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>We updated the return signature for GetTransfers and as such need to
>update the corresponding unit test
>
>Test plan
>1/ Run t/db_dependent/Circulation/transfers.t
>2/ Confirm it passes
>3/ Signoff
>
>Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <joonas.kylmala@helsinki.fi>
>---
> t/db_dependent/Circulation/transfers.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Circulation/transfers.t b/t/db_dependent/Circulation/transfers.t
>index 3c53882df3..8ca9e31682 100755
>--- a/t/db_dependent/Circulation/transfers.t
>+++ b/t/db_dependent/Circulation/transfers.t
>@@ -130,7 +130,7 @@ is(CreateBranchTransferLimit(undef,$branchcode_2),undef,
> my @transfers = GetTransfers($item_id1);
> cmp_deeply(
>     \@transfers,
>-    [ re('^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$'), $branchcode_1, $branchcode_2, re('[0-9]*') ],
>+    [ re('^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$'), $branchcode_1, $branchcode_2, re('[0-9]*'), re('^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$'), undef ],
>     "Transfers of the item1"
> );    #NOTE: Only the first transfer is returned
> @transfers = GetTransfers;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24446: 105943 | 105944 | 105945 | 107246 | 107247 | 107248 | 107249 | 107250 | 107252 | 107253 | 107254 | 107255 | 107256 | 107301 | 107302 | 107303 | 107304 | 107305 | 110280 | 110281 | 110282 | 110283 | 110533 | 110534 | 110535 | 110536 | 110537 | 110538 | 110539 | 110540 | 110541 | 110542 | 111322 | 116557 | 116558 | 116559 | 116560 | 116561 | 116562 | 116563 | 116564 | 116565 | 116566 | 116567 | 116568 | 116569 | 116570 | 117589 | 117590 | 117591 | 117592 | 117593 | 117594 | 117595 | 117596 | 117597 | 117598 | 117599 | 117600 | 117601 | 117602 | 117603 | 117604 | 117605 | 117606 | 117607 | 120116