Attachment 117604 Details for Bug 24446 – Bug 24446: (QA follow-up) Set TransferTrigger to 'Reserve' for bug 24298

[patch] Bug 24446: (QA follow-up) Set TransferTrigger to 'Reserve' for bug 24298

Bug-24446-QA-follow-up-Set-TransferTrigger-to-Rese.patch (text/plain), 1.09 KB, created by Jonathan Druart on 2021-03-03 14:32:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-03-03 14:32:38 UTC

Size: 1.09 KB

patch

obsolete

>From 1ef952489b17ac2139d5aac0abd0fd7bb55e5f95 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 18 Feb 2021 08:42:48 +0000
>Subject: [PATCH] Bug 24446: (QA follow-up) Set TransferTrigger to 'Reserve'
> for bug 24298
>
>The SIP initiated transfer was set to use the 'TransferTrigger' passed
>back from AddReturn; However, TransferTrigger is not set for reserves in
>AddReturn (It's is set controller side by circ/returns.pl). We thus need
>to also hard code the trigger type in the SIP transaction for reserves.
>---
> C4/SIP/ILS/Transaction/Checkin.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm
>index f674314e12..4792f73574 100644
>--- a/C4/SIP/ILS/Transaction/Checkin.pm
>+++ b/C4/SIP/ILS/Transaction/Checkin.pm
>@@ -154,7 +154,7 @@ sub do_checkin {
>             ModItemTransfer( $item->itemnumber,
>                 $branch,
>                 $messages->{ResFound}->{branchcode},
>-                $messages->{TransferTrigger},
>+                'Reserve',
>             );
> 
>         }
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24446: 105943 | 105944 | 105945 | 107246 | 107247 | 107248 | 107249 | 107250 | 107252 | 107253 | 107254 | 107255 | 107256 | 107301 | 107302 | 107303 | 107304 | 107305 | 110280 | 110281 | 110282 | 110283 | 110533 | 110534 | 110535 | 110536 | 110537 | 110538 | 110539 | 110540 | 110541 | 110542 | 111322 | 116557 | 116558 | 116559 | 116560 | 116561 | 116562 | 116563 | 116564 | 116565 | 116566 | 116567 | 116568 | 116569 | 116570 | 117589 | 117590 | 117591 | 117592 | 117593 | 117594 | 117595 | 117596 | 117597 | 117598 | 117599 | 117600 | 117601 | 117602 | 117603 | 117604 | 117605 | 117606 | 117607 | 120116