Attachment 117605 Details for Bug 24446 – Bug 24446: (QA follow-up) SIP test fix for bug 27166

[patch] Bug 24446: (QA follow-up) SIP test fix for bug 27166

Bug-24446-QA-follow-up-SIP-test-fix-for-bug-27166.patch (text/plain), 1.54 KB, created by Jonathan Druart on 2021-03-03 14:32:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-03-03 14:32:42 UTC

Size: 1.54 KB

patch

obsolete

>From 44a5aea34d12404d669a2ff47b004ca1db064cde Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 18 Feb 2021 08:43:25 +0000
>Subject: [PATCH] Bug 24446: (QA follow-up) SIP test fix for bug 27166
>
>A new test was introduced in bug 27166 since this code was written, this
>patch simply updates the test for the additional 'TransferTrigger'
>message that is returned by this patchset.
>---
> t/db_dependent/SIP/Transaction.t | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/SIP/Transaction.t b/t/db_dependent/SIP/Transaction.t
>index ee29265998..a3587bdee1 100755
>--- a/t/db_dependent/SIP/Transaction.t
>+++ b/t/db_dependent/SIP/Transaction.t
>@@ -324,7 +324,17 @@ subtest do_checkin => sub {
> 
>     my $result  = $ci_transaction->do_checkin($library2->branchcode, undef);
>     is($ci_transaction->alert_type,'04',"Checkin of item no issued at another branch succeeds");
>-    is_deeply($result,{ messages => { 'NotIssued' => $item->barcode, 'WasTransfered' => 1 } },"Messages show not issued and transferred");
>+    is_deeply(
>+        $result,
>+        {
>+            messages => {
>+                'NotIssued'       => $item->barcode,
>+                'WasTransfered'   => $library->branchcode,
>+                'TransferTrigger' => 'ReturnToHome'
>+            }
>+        },
>+        "Messages show not issued and transferred"
>+    );
>     is( $ci_transaction->item->destination_loc,$library->branchcode,"Item destination correctly set");
> 
>     subtest 'Checkin an in transit item' => sub {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24446: 105943 | 105944 | 105945 | 107246 | 107247 | 107248 | 107249 | 107250 | 107252 | 107253 | 107254 | 107255 | 107256 | 107301 | 107302 | 107303 | 107304 | 107305 | 110280 | 110281 | 110282 | 110283 | 110533 | 110534 | 110535 | 110536 | 110537 | 110538 | 110539 | 110540 | 110541 | 110542 | 111322 | 116557 | 116558 | 116559 | 116560 | 116561 | 116562 | 116563 | 116564 | 116565 | 116566 | 116567 | 116568 | 116569 | 116570 | 117589 | 117590 | 117591 | 117592 | 117593 | 117594 | 117595 | 117596 | 117597 | 117598 | 117599 | 117600 | 117601 | 117602 | 117603 | 117604 | 117605 | 117606 | 117607 | 120116