Attachment 117607 Details for Bug 24446 – Bug 24446: (QA follow-up) Use 'receive' method in ModReserveAffect

[patch] Bug 24446: (QA follow-up) Use 'receive' method in ModReserveAffect

Bug-24446-QA-follow-up-Use-receive-method-in-ModRe.patch (text/plain), 1.40 KB, created by Jonathan Druart on 2021-03-03 14:32:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-03-03 14:32:49 UTC

Size: 1.40 KB

patch

obsolete

>From c723e02b3966ff4c325d11cb1e5dd59fda99ea26 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 18 Feb 2021 14:45:38 +0000
>Subject: [PATCH] Bug 24446: (QA follow-up) Use 'receive' method in
> ModReserveAffect
>
>ModeReserveAffect was setting all transfers in the queue to received by
>looping through a resultset. This patch updates the logic to try and
>catch the in_transit transfer and receive just that one instead.
>---
> C4/Reserves.pm | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
>diff --git a/C4/Reserves.pm b/C4/Reserves.pm
>index db236947c5..d5f90494eb 100644
>--- a/C4/Reserves.pm
>+++ b/C4/Reserves.pm
>@@ -1200,16 +1200,11 @@ sub ModReserveAffect {
>     } else {
>         $hold->set_waiting($desk_id);
>         _koha_notify_reserve( $hold->reserve_id ) unless $already_on_shelf;
>-        my $transfers = Koha::Item::Transfers->search({
>-            itemnumber => $itemnumber,
>-            datearrived => undef
>-        });
>-        while( my $transfer = $transfers->next ){
>-            $transfer->datearrived( dt_from_string() )->store;
>-        };
>+        # Complete transfer if one exists
>+        my $transfer = $hold->item->get_transfer;
>+        $transfer->receive if $transfer;
>     }
> 
>-
>     _FixPriority( { biblionumber => $biblionumber } );
>     my $item = Koha::Items->find($itemnumber);
>     if ( $item->location && $item->location eq 'CART'
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24446: 105943 | 105944 | 105945 | 107246 | 107247 | 107248 | 107249 | 107250 | 107252 | 107253 | 107254 | 107255 | 107256 | 107301 | 107302 | 107303 | 107304 | 107305 | 110280 | 110281 | 110282 | 110283 | 110533 | 110534 | 110535 | 110536 | 110537 | 110538 | 110539 | 110540 | 110541 | 110542 | 111322 | 116557 | 116558 | 116559 | 116560 | 116561 | 116562 | 116563 | 116564 | 116565 | 116566 | 116567 | 116568 | 116569 | 116570 | 117589 | 117590 | 117591 | 117592 | 117593 | 117594 | 117595 | 117596 | 117597 | 117598 | 117599 | 117600 | 117601 | 117602 | 117603 | 117604 | 117605 | 117606 | 117607 | 120116