Attachment 117614 Details for Bug 27745 – Bug 27745: prevent warning for uninitialized value as a hash key

[patch] Bug 27745: prevent warning for uninitialized value as a hash key

Bug-27745-prevent-warning-for-uninitialized-value-.patch (text/plain), 1.93 KB, created by Didier Gautheron on 2021-03-03 15:15:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Didier Gautheron

Created: 2021-03-03 15:15:49 UTC

Size: 1.93 KB

patch

obsolete

>From f570f776087809ebe0632f4b5fe2bf8c3bdedbfb Mon Sep 17 00:00:00 2001
>From: Petro Vashchuk <stalkernoid@gmail.com>
>Date: Wed, 3 Mar 2021 11:32:48 +0200
>Subject: [PATCH] Bug 27745: prevent warning for uninitialized value as a hash
> key
>
>When you edit and save items with an empty "c - Shelving location"
>field, it gets stored into the database as "NULL",
>which is allowed in the database, and the field is not "required",
>so this seems expected.
>
>But when the search page is rendered, it gets value by location key
>($shelflocations->{ $item->{location} }) which gives undef warning.
>
>Solved by checking if $item->{location} is perl true.
>
>To reproduce:
>    1) Edit the book or create new one with an empty shelving location.
>    2) Use the search feature to have that book in the searched list.
>    3) Check plack-intranet-error.log to find "Use of uninitialized
>value in hash element" error.
>    4) Apply the patch.
>    5) Repeat the search and check the logs again to ensure that error
>didn't appear again.
>
>Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com>
>---
> C4/Search.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Search.pm b/C4/Search.pm
>index f5f91db4a6..4413211849 100644
>--- a/C4/Search.pm
>+++ b/C4/Search.pm
>@@ -1875,7 +1875,7 @@ sub searchResults {
>                 $onloan_items->{$key}->{due_date} = $item->{onloan};
>                 $onloan_items->{$key}->{count}++ if $item->{$hbranch};
>                 $onloan_items->{$key}->{branchname}     = $item->{branchname};
>-                $onloan_items->{$key}->{location}       = $shelflocations->{ $item->{location} };
>+                $onloan_items->{$key}->{location}       = $shelflocations->{ $item->{location} } if $item->{location};
>                 $onloan_items->{$key}->{itemcallnumber} = $item->{itemcallnumber};
>                 $onloan_items->{$key}->{description}    = $item->{description};
>                 $onloan_items->{$key}->{imageurl} =
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27745: 117138 | 117554 | 117614 | 117783