Attachment 117637 Details for Bug 22824 – Bug 22824: Replace YAML::Syck with YAML::XS in tests

[patch] Bug 22824: Replace YAML::Syck with YAML::XS in tests

Bug-22824-Replace-YAMLSyck-with-YAMLXS-in-tests.patch (text/plain), 1.33 KB, created by Martin Renvoize (ashimema) on 2021-03-04 09:19:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-03-04 09:19:20 UTC

Size: 1.33 KB

patch

obsolete

>From a9210be90221220d46357484d7230443670f178a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 11 Feb 2021 10:09:48 +0100
>Subject: [PATCH] Bug 22824: Replace YAML::Syck with YAML::XS in tests
>
>In order to understand how things will work after the changes
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/db_dependent/yaml.t | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
>diff --git a/t/db_dependent/yaml.t b/t/db_dependent/yaml.t
>index 177ce18f05..ddb2b63da9 100755
>--- a/t/db_dependent/yaml.t
>+++ b/t/db_dependent/yaml.t
>@@ -1,22 +1,17 @@
> use Modern::Perl;
> use Test::More;
> 
>-use YAML::Syck;
>+use YAML::XS;
> use Template;
> use utf8;
> 
>-$YAML::Syck::ImplicitTyping = 1;
>-$YAML::Syck::ImplicitUnicode = 1;
>-
> my $template = Template->new( ENCODING => 'UTF-8' );
> 
> my $vars;
> my $output;
> $template->process( 't/db_dependent/data/syspref.pref', $vars, \$output );
> 
>-use Data::Printer colored => 1; warn p $output;
>-
>-my $yaml = YAML::Syck::Load( $output );
>+my $yaml = YAML::XS::Load( $output );
> my $syspref_1 = $yaml->{Test}->{Testing}->[0];
> my $syspref_2 = $yaml->{Test}->{Testing}->[1];
> my $syspref_3 = $yaml->{Test}->{Testing}->[2];
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22824: 116722 | 116723 | 116724 | 116725 | 116726 | 116727 | 116728 | 116729 | 116730 | 116731 | 116732 | 116733 | 116734 | 116735 | 116736 | 116741 | 116742 | 116743 | 116744 | 116745 | 116746 | 116747 | 116748 | 116749 | 116750 | 116751 | 116752 | 116753 | 116754 | 116755 | 116756 | 116881 | 116882 | 116883 | 116884 | 117037 | 117039 | 117040 | 117041 | 117042 | 117043 | 117044 | 117045 | 117046 | 117047 | 117048 | 117049 | 117050 | 117051 | 117052 | 117053 | 117054 | 117055 | 117056 | 117057 | 117058 | 117636 | 117637 | 117638 | 117639 | 117640 | 117641 | 117642 | 117643 | 117644 | 117645 | 117646 | 117647 | 117648 | 117649 | 117650 | 117651 | 117652 | 117653 | 117664 | 117666