Attachment 117641 Details for Bug 22824 – Bug 22824: Correct on/off behaviour

[patch] Bug 22824: Correct on/off behaviour

Bug-22824-Correct-onoff-behaviour.patch (text/plain), 5.84 KB, created by Martin Renvoize (ashimema) on 2021-03-04 09:19:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-03-04 09:19:35 UTC

Size: 5.84 KB

patch

obsolete

>From f7267fddbd1e22801ec05ed01c384d4bb5b5053e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 11 Feb 2021 11:49:54 +0100
>Subject: [PATCH] Bug 22824: Correct on/off behaviour
>
>Here things are starting to be a bit tricky.
>IMO we don't want to replicate the ImplicitTyping behaviour from
>YAML::Syck but handle correctly the different value.
>We have the list of available values in the .pref file, the values in DB
>must match them.
>
>We want 1 or 0 in DB.
>
>2 more occurrences:
>finesMode => Dealt on bug 27676 ('off' is ok here)
>itemBarcodeInputFilter => 'OFF' is correct here
>
>Note that we don't use ~ or true/false in *.pref
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../en/modules/admin/preferences/logs.pref    | 72 +++++++++----------
> 1 file changed, 36 insertions(+), 36 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref
>index 2d717fc165..490a69569d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref
>@@ -3,110 +3,110 @@ Logging:
>         -
>             - pref: LetterLog
>               choices:
>-                  on: Log
>-                  off: "Don't log"
>+                  1: Log
>+                  0: "Don't log"
>             - when an automatic claim notice is sent.
>         -
>             - pref: BorrowersLog
>               choices:
>-                  on: Log
>-                  off: "Don't log"
>+                  1: Log
>+                  0: "Don't log"
>             - changes to patron records.
>         -
>             - pref: CataloguingLog
>               choices:
>-                  on: Log
>-                  off: "Don't log"
>+                  1: Log
>+                  0: "Don't log"
>             - any changes to bibliographic or item records.
>         -
>             - pref: AuthoritiesLog
>               choices:
>-                  on: Log
>-                  off: "Don't log"
>+                  1: Log
>+                  0: "Don't log"
>             - changes to authority records.
>         -
>             - pref: FinesLog
>               choices:
>-                  on: Log
>-                  off: "Don't log"
>+                  1: Log
>+                  0: "Don't log"
>             - when fines are charged, paid, or forgiven.
>         -
>             - pref: HoldsLog
>               choices:
>-                  on: Log
>-                  off: "Don't log"
>+                  1: Log
>+                  0: "Don't log"
>             - any actions on holds (create, cancel, suspend, resume, etc).
>         -
>             - pref: IllLog
>               choices:
>-                  on: Log
>-                  off: "Don't log"
>+                  1: Log
>+                  0: "Don't log"
>             - when changes to ILL requests take place.
>         -
>             - pref: IssueLog
>               choices:
>-                  on: Log
>-                  off: "Don't log"
>+                  1: Log
>+                  0: "Don't log"
>             - when items are checked out.
>         -
>             - pref: ReturnLog
>               choices:
>-                  on: Log
>-                  off: "Don't log"
>+                  1: Log
>+                  0: "Don't log"
>             - when items are checked in.
>         -
>             - pref: RenewalLog
>               choices:
>-                  on: Log
>-                  off: "Don't log"
>+                  1: Log
>+                  0: "Don't log"
>             - when items are renewed.
>         -
>             - pref: SubscriptionLog
>               choices:
>-                  on: Log
>-                  off: "Don't log"
>+                  1: Log
>+                  0: "Don't log"
>             - when serials are added, deleted or changed.
>         -
>             - pref: CronjobLog
>               choices:
>-                  on: Log
>-                  off: "Don't log"
>+                  1: Log
>+                  0: "Don't log"
>             - information from cron jobs.
>         -
>             - pref: ReportsLog
>               choices:
>-                  on: Log
>-                  off: "Don't log"
>+                  1: Log
>+                  0: "Don't log"
>             - when reports are added, deleted or changed.
>         -
>             - pref: AuthFailureLog
>               choices:
>-                  on: Log
>-                  off: "Don't log"
>+                  1: Log
>+                  0: "Don't log"
>             - " authentication failures."
>         -
>             - pref: AuthSuccessLog
>               choices:
>-                  on: Log
>-                  off: "Don't log"
>+                  1: Log
>+                  0: "Don't log"
>             - " successful authentications."
> 
>     Debugging:
>         -
>             - pref: DumpTemplateVarsIntranet
>               choices:
>-                  on: Do
>-                  off: "Don't"
>+                  1: Do
>+                  0: "Don't"
>             - dump all Template Toolkit variables to a comment in the HTML source for the staff interface.
>         -
>             - pref: DumpTemplateVarsOpac
>               choices:
>-                  on: Do
>-                  off: "Don't"
>+                  1: Do
>+                  0: "Don't"
>             - dump all Template Toolkit variables to a comment in the HTML source for the OPAC.
>         -
>             - pref: DumpSearchQueryTemplate
>               choices:
>-                  on: Do
>-                  off: "Don't"
>+                  1: Do
>+                  0: "Don't"
>             - dump search query as a template parameter, requires <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=DumpTemplateVars">DumpTemplateVars</a>[interface] to be visible.
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22824: 116722 | 116723 | 116724 | 116725 | 116726 | 116727 | 116728 | 116729 | 116730 | 116731 | 116732 | 116733 | 116734 | 116735 | 116736 | 116741 | 116742 | 116743 | 116744 | 116745 | 116746 | 116747 | 116748 | 116749 | 116750 | 116751 | 116752 | 116753 | 116754 | 116755 | 116756 | 116881 | 116882 | 116883 | 116884 | 117037 | 117039 | 117040 | 117041 | 117042 | 117043 | 117044 | 117045 | 117046 | 117047 | 117048 | 117049 | 117050 | 117051 | 117052 | 117053 | 117054 | 117055 | 117056 | 117057 | 117058 | 117636 | 117637 | 117638 | 117639 | 117640 | 117641 | 117642 | 117643 | 117644 | 117645 | 117646 | 117647 | 117648 | 117649 | 117650 | 117651 | 117652 | 117653 | 117664 | 117666