Attachment 117645 Details for Bug 22824 – Bug 22824: Fix default values for YesNo

[patch] Bug 22824: Fix default values for YesNo

Bug-22824-Fix-default-values-for-YesNo.patch (text/plain), 12.15 KB, created by Martin Renvoize (ashimema) on 2021-03-04 09:19:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-03-04 09:19:52 UTC

Size: 12.15 KB

patch

obsolete

>From 34141845d2962386852b7539535368d07be57138 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 11 Feb 2021 12:31:05 +0100
>Subject: [PATCH] Bug 22824: Fix default values for YesNo
>
>select variable, value from systempreferences where type="YesNo" and ( ( value <>'1' and value <>'0' ) or value is null );
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> installer/data/mysql/mandatory/sysprefs.sql | 22 ++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
>diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql
>index e68c4c3a52..3ead03b283 100644
>--- a/installer/data/mysql/mandatory/sysprefs.sql
>+++ b/installer/data/mysql/mandatory/sysprefs.sql
>@@ -61,13 +61,13 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('ArticleRequestsMandatoryFieldsRecordOnly', '', NULL, 'Comma delimited list of required fields for bibs where article requests rule = ''bib_only''', 'multiple'),
> ('AudioAlerts','0','','Enable circulation sounds during checkin and checkout in the staff interface.  Not supported by all web browsers yet.','YesNo'),
> ('AuthDisplayHierarchy','0','','Display authority hierarchies','YesNo'),
>-('AuthFailureLog','',NULL,'If enabled, log authentication failures','YesNo'),
>+('AuthFailureLog','0',NULL,'If enabled, log authentication failures','YesNo'),
> ('AuthoritiesLog','1',NULL,'If ON, log edit/create/delete actions on authorities.','YesNo'),
> ('AuthorityControlledIndicators','# PERSO_NAME  100 600 696 700 796 800 896\nmarc21, 100, ind1:auth1\nmarc21, 600, ind1:auth1, ind2:thesaurus\nmarc21, 696, ind1:auth1\nmarc21, 700, ind1:auth1\nmarc21, 796, ind1:auth1\nmarc21, 800, ind1:auth1\nmarc21, 896, ind1:auth1\n# CORPO_NAME  110 610 697 710 797 810 897\nmarc21, 110, ind1:auth1\nmarc21, 610, ind1:auth1, ind2:thesaurus\nmarc21, 697, ind1:auth1\nmarc21, 710, ind1:auth1\nmarc21, 797, ind1:auth1\nmarc21, 810, ind1:auth1\nmarc21, 897, ind1:auth1\n# MEETI_NAME    111 611 698 711 798 811 898\nmarc21, 111, ind1:auth1\nmarc21, 611, ind1:auth1, ind2:thesaurus\nmarc21, 698, ind1:auth1\nmarc21, 711, ind1:auth1\nmarc21, 798, ind1:auth1\nmarc21, 811, ind1:auth1\nmarc21, 898, ind1:auth1\n# UNIF_TITLE        130 440 630 699 730 799 830 899\nmarc21, 130, ind1:auth2\nmarc21, 240, , ind2:auth2\nmarc21, 440, , ind2:auth2\nmarc21, 630, ind1:auth2, ind2:thesaurus\nmarc21, 699, ind1:auth2\nmarc21, 730, ind1:auth2\nmarc21, 799, ind1:auth2\nmarc21, 830, , ind2:auth2\nmarc21, 899, ind1:auth2\n# CHRON_TERM    648 \nmarc21, 648, , ind2:thesaurus\n# TOPIC_TERM      650 654 656 657 658 690\nmarc21, 650, , ind2:thesaurus\n# GEOGR_NAME   651 662 691\nmarc21, 651, , ind2:thesaurus\n# GENRE/FORM    655 \nmarc21, 655, , ind2:thesaurus\n\n# UNIMARC: Always copy the indicators from the authority\nunimarc, *, ind1:auth1, ind2:auth2',NULL,'Authority controlled indicators per biblio field','Free'),
> ('AuthorityMergeLimit','50',NULL,'Maximum number of biblio records updated immediately when an authority record has been modified.','integer'),
> ('AuthorityMergeMode','loose','loose|strict','Authority merge mode','Choice'),
> ('AuthoritySeparator','--','10','Used to separate a list of authorities in a display. Usually --','free'),
>-('AuthSuccessLog','',NULL,'If enabled, log successful authentications','YesNo'),
>+('AuthSuccessLog','0',NULL,'If enabled, log successful authentications','YesNo'),
> ('autoBarcode','OFF','incremental|annual|hbyymmincr|EAN13|OFF','Used to autogenerate a barcode: incremental will be of the form 1, 2, 3; annual of the form 2007-0001, 2007-0002; hbyymmincr of the form HB08010001 where HB=Home Branch','Choice'),
> ('AutoCreateAuthorities','0',NULL,'Automatically create authorities that do not exist when cataloging records.','YesNo'),
> ('AutoCreditNumber', '', '', 'Automatically generate a number for account credits', 'Choice'),
>@@ -145,7 +145,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('CustomCoverImagesURL','',NULL,'Define an URL serving book cover images, using the following patterns: %issn%, %isbn%, FIXME ADD MORE (use it with CustomCoverImages and/or OPACCustomCoverImages)','free'),
> ('dateformat','us','metric|us|iso|dmydot','Define global date format (us mm/dd/yyyy, metric dd/mm/yyy, ISO yyyy-mm-dd, dmydot dd.mm.yyyy)','Choice'),
> ('DebugLevel','2','0|1|2','Define the level of debugging information sent to the browser when errors are encountered (set to 0 in production). 0=none, 1=some, 2=most','Choice'),
>-('decreaseLoanHighHolds',NULL,'','Decreases the loan period for items with number of holds above the threshold specified in decreaseLoanHighHoldsValue','YesNo'),
>+('decreaseLoanHighHolds','0','','Decreases the loan period for items with number of holds above the threshold specified in decreaseLoanHighHoldsValue','YesNo'),
> ('decreaseLoanHighHoldsControl', 'static', 'static|dynamic', "Chooses between static and dynamic high holds checking", 'Choice'),
> ('decreaseLoanHighHoldsDuration',NULL,'','Specifies a number of days that a loan is reduced to when used in conjunction with decreaseLoanHighHolds','Integer'),
> ('decreaseLoanHighHoldsIgnoreStatuses', '', 'damaged|itemlost|notforloan|withdrawn', "Ignore items with these statuses for dynamic high holds checking", 'Choice'),
>@@ -258,7 +258,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('IndependentBranchesPatronModifications','0', NULL, 'Show only modification request for the logged in branch','YesNo'),
> ('IndependentBranchesTransfers','0', NULL, 'Allow non-superlibrarians to transfer items between libraries','YesNo'),
> ('IntranetCatalogSearchPulldown','0', NULL, 'Show a search field pulldown for \"Search the catalog\" boxes','YesNo'),
>-('RecordedBooksClientSecret','','30','Client key for RecordedBooks integration','YesNo'),
>+('RecordedBooksClientSecret','','30','Client key for RecordedBooks integration','Free'),
> ('RecordedBooksDomain','','','RecordedBooks domain','Free'),
> ('RecordedBooksLibraryID','','','Library ID for RecordedBooks integration','Integer'),
> ('OnSiteCheckouts','0','','Enable/Disable the on-site checkouts feature','YesNo'),
>@@ -285,7 +285,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('IssueLostItem','alert','Defines what should be done when an attempt is made to issue an item that has been marked as lost.','alert|confirm|nothing','Choice'),
> ('IssuingInProcess','0',NULL,'If ON, disables fines if the patron is issuing item that accumulate debt','YesNo'),
> ('item-level_itypes','1','','If ON, enables Item-level Itemtype / Issuing Rules','YesNo'),
>-('itemBarcodeFallbackSearch','',NULL,'If set, uses scanned item barcodes as a catalogue search if not found as barcodes','YesNo'),
>+('itemBarcodeFallbackSearch','0',NULL,'If set, uses scanned item barcodes as a catalogue search if not found as barcodes','YesNo'),
> ('itemBarcodeInputFilter','','whitespace|T-prefix|cuecat|libsuite8|EAN13','If set, allows specification of a item barcode input filter','Choice'),
> ('itemcallnumber','',NULL,'The MARC field/subfield that is used to calculate the itemcallnumber (Dewey would be 082ab or 092ab; LOC would be 050ab or 090ab) could be 852hi from an item record','free'),
> ('ItemsDeniedRenewal','','','This syspref allows to define custom rules for denying renewal of specific items.','Textarea'),
>@@ -483,15 +483,15 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('OpenURLText', '', NULL, 'Text of OpenURL links (or image title if OpenURLImageLocation is defined)', 'Free'),
> ('OpenURLImageLocation', '', NULL, 'Location of image for OpenURL links', 'Free'),
> ('OPACFineNoRenewalsIncludeCredits','1',NULL,'If enabled the value specified in OPACFineNoRenewals should include any unapplied account credits in the calculation','YesNo'),
>-('OPACShowOpenURL', '', NULL, 'Enable display of OpenURL links in OPAC search results and detail page', 'YesNo'),
>+('OPACShowOpenURL', '0', NULL, 'Enable display of OpenURL links in OPAC search results and detail page', 'YesNo'),
> ('OPACOpenURLItemTypes', '', NULL, 'Show the OpenURL link only for these item types', 'Free'),
> ('OrderPdfFormat','pdfformat::layout3pages','Controls what script is used for printing (basketgroups)','','free'),
> ('OrderPriceRounding','','|nearest_cent','Local preference for rounding orders before calculations to ensure correct calculations','Choice'),
> ('OverDriveCirculation','0','Enable client to see their OverDrive account','','YesNo'),
> ('OverDriveClientKey','','Client key for OverDrive integration','30','Free'),
>-('OverDriveClientSecret','','Client key for OverDrive integration','30','YesNo'),
>+('OverDriveClientSecret','','Client key for OverDrive integration','30','Free'),
> ('OverDriveLibraryID','','Library ID for OverDrive integration','','Integer'),
>-('OverDrivePasswordRequired','',NULL,'Does the library require passwords for OverDrive SIP authentication','YesNo'),
>+('OverDrivePasswordRequired','0',NULL,'Does the library require passwords for OverDrive SIP authentication','YesNo'),
> ('OverDriveUsername','cardnumber','cardnumber|userid','Which patron information should be passed as OverDrive username','Choice'),
> ('OverdueNoticeCalendar',0,NULL,'Take the calendar into consideration when generating overdue notices','YesNo'),
> ('OverduesBlockCirc','noblock','noblock|confirmation|block','When checking out an item should overdues block checkout, generate a confirmation dialogue, or allow checkout','Choice'),
>@@ -688,12 +688,12 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('UploadPurgeTemporaryFilesDays','',NULL,'If not empty, number of days used when automatically deleting temporary uploads','integer'),
> ('uppercasesurnames','0',NULL,'If ON, surnames are converted to upper case in patron entry form','YesNo'),
> ('URLLinkText','',NULL,'Text to display as the link anchor in the OPAC','free'),
>-('UsageStats', 2, NULL, 'Share anonymous usage data on the Hea Koha community website.', 'YesNo'),
>+('UsageStats', 2, NULL, 'Share anonymous usage data on the Hea Koha community website.', 'integer'),
> ('UsageStatsCountry', '', NULL, 'The country where your library is located, to be shown on the Hea Koha community website', 'Choice'),
> ('UsageStatsID', '', NULL, 'This preference is part of Koha but it should not be deleted or updated manually.',  'Free'),
> ('UsageStatsGeolocation', '', NULL, 'Geolocation of the main library.', 'Free'),
> ('UsageStatsLastUpdateTime', '', NULL, 'This preference is part of Koha but it should not be deleted or updated manually.', 'Free'),
>-('UsageStatsLibrariesInfo', '', NULL, 'Share libraries information', 'YesNo'),
>+('UsageStatsLibrariesInfo', '0', NULL, 'Share libraries information', 'YesNo'),
> ('UsageStatsLibraryName', '', NULL, 'The library name to be shown on Hea Koha community website', 'Free'),
> ('UsageStatsLibraryType', '', 'public|school|academic|research|private|societyAssociation|corporate|government|religiousOrg|subscription', 'The library type to be shown on the Hea Koha community website', 'Choice'),
> ('UsageStatsLibraryUrl', '', NULL, 'The library URL to be shown on Hea Koha community website', 'Free'),
>@@ -707,7 +707,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('UseCourseReserves','0',NULL,'Enable the course reserves feature.','YesNo'),
> ('useDaysMode','Calendar','Calendar|Days|Datedue|Dayweek','Choose the method for calculating due date: select Calendar, Datedue or Dayweek to use the holidays module, and Days to ignore the holidays module','Choice'),
> ('useDefaultReplacementCost', '0', NULL, 'default replacement cost defined in item type', 'YesNo'),
>-('useDischarge','','','Allows librarians to discharge borrowers and borrowers to request a discharge','YesNo'),
>+('useDischarge','0','','Allows librarians to discharge borrowers and borrowers to request a discharge','YesNo'),
> ('UseEmailReceipts','0','','Send email receipts for payments and write-offs','YesNo'),
> ('UseICUStyleQuotes','0','1','Tell Koha whether to use ICU style quotes ({) or default (") when tracing subjects .','YesNo'),
> ('UseTransportCostMatrix','0','','Use Transport Cost Matrix when filling holds','YesNo'),
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22824: 116722 | 116723 | 116724 | 116725 | 116726 | 116727 | 116728 | 116729 | 116730 | 116731 | 116732 | 116733 | 116734 | 116735 | 116736 | 116741 | 116742 | 116743 | 116744 | 116745 | 116746 | 116747 | 116748 | 116749 | 116750 | 116751 | 116752 | 116753 | 116754 | 116755 | 116756 | 116881 | 116882 | 116883 | 116884 | 117037 | 117039 | 117040 | 117041 | 117042 | 117043 | 117044 | 117045 | 117046 | 117047 | 117048 | 117049 | 117050 | 117051 | 117052 | 117053 | 117054 | 117055 | 117056 | 117057 | 117058 | 117636 | 117637 | 117638 | 117639 | 117640 | 117641 | 117642 | 117643 | 117644 | 117645 | 117646 | 117647 | 117648 | 117649 | 117650 | 117651 | 117652 | 117653 | 117664 | 117666