Attachment 117648 Details for Bug 22824 – Bug 22824: Adjust tests to match final behaviours

[patch] Bug 22824: Adjust tests to match final behaviours

Bug-22824-Adjust-tests-to-match-final-behaviours.patch (text/plain), 1.78 KB, created by Martin Renvoize (ashimema) on 2021-03-04 09:20:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-03-04 09:20:04 UTC

Size: 1.78 KB

patch

obsolete

>From e67b84fde494c8b1682c23be9e05ea852a58065e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 11 Feb 2021 14:27:56 +0100
>Subject: [PATCH] Bug 22824: Adjust tests to match final behaviours
>
>Finally we diverge quite a lot with how it worked prior to this patch
>set. Reflect the changes in the tests
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/db_dependent/data/syspref.pref | 2 +-
> t/db_dependent/yaml.t            | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/t/db_dependent/data/syspref.pref b/t/db_dependent/data/syspref.pref
>index c5cee1efb6..90c3648c74 100644
>--- a/t/db_dependent/data/syspref.pref
>+++ b/t/db_dependent/data/syspref.pref
>@@ -23,6 +23,6 @@ Test:
>             - "List of fields"
>             - pref: syspref_4
>               choices:
>-                  020: 020
>+                  "16" : "16"
>                   "020": "020"
>                   "123": "123"
>diff --git a/t/db_dependent/yaml.t b/t/db_dependent/yaml.t
>index 661d5edae2..586c053ca0 100755
>--- a/t/db_dependent/yaml.t
>+++ b/t/db_dependent/yaml.t
>@@ -23,8 +23,8 @@ is_deeply(
>         "Do it",
>         {
>             choices => {
>-                1  => "certainly",
>-                '' => "I don't think so"
>+                on  => "certainly",
>+                off => "I don't think so"
>             },
>             pref => "syspref_1"
>         }
>@@ -50,7 +50,7 @@ is_deeply(
>         "We love unicode",
>         {
>             choices => {
>-                ''    => "Not really",
>+                no  => "Not really",
>                 'â' => "â¤ï¸"
>             },
>             pref => "syspref_3"
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22824: 116722 | 116723 | 116724 | 116725 | 116726 | 116727 | 116728 | 116729 | 116730 | 116731 | 116732 | 116733 | 116734 | 116735 | 116736 | 116741 | 116742 | 116743 | 116744 | 116745 | 116746 | 116747 | 116748 | 116749 | 116750 | 116751 | 116752 | 116753 | 116754 | 116755 | 116756 | 116881 | 116882 | 116883 | 116884 | 117037 | 117039 | 117040 | 117041 | 117042 | 117043 | 117044 | 117045 | 117046 | 117047 | 117048 | 117049 | 117050 | 117051 | 117052 | 117053 | 117054 | 117055 | 117056 | 117057 | 117058 | 117636 | 117637 | 117638 | 117639 | 117640 | 117641 | 117642 | 117643 | 117644 | 117645 | 117646 | 117647 | 117648 | 117649 | 117650 | 117651 | 117652 | 117653 | 117664 | 117666