Attachment 117657 Details for Bug 18729 – Bug 18729: Add more tests

[patch] Bug 18729: Add more tests

Bug-18729-Add-more-tests.patch (text/plain), 4.94 KB, created by David Nind on 2021-03-04 09:46:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2021-03-04 09:46:41 UTC

Size: 4.94 KB

patch

obsolete

>From 16ff287d382bd2403be10556b52e96e3b8d5e303 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 11 Dec 2020 09:11:15 -0300
>Subject: [PATCH] Bug 18729: Add more tests
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> t/db_dependent/api/v1/holds.t | 79 ++++++++++++++++++++++++++++++++++++++++---
> 1 file changed, 75 insertions(+), 4 deletions(-)
>
>diff --git a/t/db_dependent/api/v1/holds.t b/t/db_dependent/api/v1/holds.t
>index 3796c9175d..ccf6efa879 100755
>--- a/t/db_dependent/api/v1/holds.t
>+++ b/t/db_dependent/api/v1/holds.t
>@@ -1027,17 +1027,17 @@ subtest 'add() tests' => sub {
>     $schema->storage->txn_rollback;
> };
> 
>-
> subtest 'PUT /holds/{hold_id}/pickup_location tests' => sub {
> 
>-    plan tests => 4;
>+    plan tests => 16;
> 
>     $schema->storage->txn_begin;
> 
>     my $password = 'AbcdEFG123';
> 
>-    my $library_1   =  $builder->build_object({ class => 'Koha::Libraries' });
>+    my $library_1 = $builder->build_object({ class => 'Koha::Libraries' });
>     my $library_2 = $builder->build_object({ class => 'Koha::Libraries' });
>+    my $library_3 = $builder->build_object({ class => 'Koha::Libraries' });
> 
>     my $patron = $builder->build_object(
>         { class => 'Koha::Patrons', value => { flags => 0 } } );
>@@ -1058,7 +1058,27 @@ subtest 'PUT /holds/{hold_id}/pickup_location tests' => sub {
>     t::lib::Mocks::mock_preference( 'HoldsLog',      0 );
>     t::lib::Mocks::mock_preference( 'RESTBasicAuth', 1 );
> 
>+    my $libraries_query = { branchcode => [ $library_1->branchcode, $library_2->branchcode ] };
>+
>+    my $mocked_biblio = Test::MockModule->new('Koha::Biblio');
>+    $mocked_biblio->mock( 'pickup_locations', sub {
>+        return Koha::Libraries->search($libraries_query);
>+    });
>+
>+    my $mocked_item = Test::MockModule->new('Koha::Item');
>+    $mocked_item->mock( 'pickup_locations', sub {
>+        return Koha::Libraries->search($libraries_query);
>+    });
>+
>     my $biblio = $builder->build_sample_biblio;
>+    my $item   = $builder->build_sample_item(
>+        {
>+            biblionumber => $biblio->biblionumber,
>+            library      => $library_1->branchcode
>+        }
>+    );
>+
>+    # biblio-level hold
>     my $hold = Koha::Holds->find(
>         AddReserve(
>             {
>@@ -1066,13 +1086,64 @@ subtest 'PUT /holds/{hold_id}/pickup_location tests' => sub {
>                 borrowernumber => $patron->borrowernumber,
>                 biblionumber   => $biblio->biblionumber,
>                 priority       => 1,
>+                itemnumber     => undef,
>+            }
>+        )
>+    );
>+
>+    $t->put_ok( "//$userid:$password@/api/v1/holds/"
>+          . $hold->id
>+          . "/pickup_location" => json => { pickup_library_id => $library_2->branchcode } )
>+      ->status_is(200)
>+      ->json_is({ pickup_library_id => $library_2->branchcode });
>+
>+    is( $hold->discard_changes->branchcode->branchcode, $library_2->branchcode, 'pickup library adjusted correctly' );
>+
>+    $libraries_query = { branchcode => $library_1->branchcode };
>+
>+    $t->put_ok( "//$userid:$password@/api/v1/holds/"
>+          . $hold->id
>+          . "/pickup_location" => json => { pickup_library_id => $library_3->branchcode } )
>+      ->status_is(400)
>+      ->json_is({ error => '[The supplied pickup location is not valid]' });
>+
>+    is( $hold->discard_changes->branchcode->branchcode, $library_2->branchcode, 'pickup library unchanged' );
>+
>+    # item-level hold
>+    $hold = Koha::Holds->find(
>+        AddReserve(
>+            {
>+                branchcode     => $library_1->branchcode,
>+                borrowernumber => $patron->borrowernumber,
>+                biblionumber   => $biblio->biblionumber,
>+                priority       => 1,
>+                itemnumber     => $item->itemnumber,
>             }
>         )
>     );
> 
>+    $libraries_query = { branchcode => $library_1->branchcode };
>+
>+    # Attempt to use an invalid pickup locations ends in 400
>+    $t->put_ok( "//$userid:$password@/api/v1/holds/"
>+          . $hold->id
>+          . "/pickup_location" => json => { pickup_library_id => $library_2->branchcode } )
>+      ->status_is(400)
>+      ->json_is({ error => '[The supplied pickup location is not valid]' });
>+
>+    is( $hold->discard_changes->branchcode->branchcode, $library_1->branchcode, 'pickup library unchanged' );
>+
>+    $libraries_query = {
>+        branchcode => {
>+            '-in' => [ $library_1->branchcode, $library_2->branchcode ]
>+        }
>+    };
>+
>     $t->put_ok( "//$userid:$password@/api/v1/holds/"
>           . $hold->id
>-          . "/pickup_location" => json => $library_2->branchcode )->status_is(200)->json_is($library_2->branchcode);
>+          . "/pickup_location" => json => { pickup_library_id => $library_2->branchcode } )
>+      ->status_is(200)
>+      ->json_is({ pickup_library_id => $library_2->branchcode });
> 
>     is( $hold->discard_changes->branchcode->branchcode, $library_2->branchcode, 'pickup library adjusted correctly' );
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 18729: 114067 | 114311 | 114337 | 114388 | 114389 | 114390 | 114391 | 114393 | 114394 | 114395 | 114396 | 117656 | 117657 | 117658 | 117659 | 119711 | 119712 | 119713 | 119714