Attachment 117674 Details for Bug 25690 – Bug 25690: (follow-up) Supress warning about unitialized string

[patch] Bug 25690: (follow-up) Supress warning about unitialized string

Bug-25690-follow-up-Supress-warning-about-unitiali.patch (text/plain), 1.52 KB, created by Joonas Kylmälä on 2021-03-04 10:34:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2021-03-04 10:34:47 UTC

Size: 1.52 KB

patch

obsolete

>From b9a482ff7e2b36f21931d201d18e894a7ebe0828 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi>
>Date: Thu, 4 Mar 2021 12:33:24 +0200
>Subject: [PATCH] Bug 25690: (follow-up) Supress warning about unitialized
> string
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This fixes the warning:
>Use of uninitialized value in string eq at /kohadevbox/koha/C4/Reserves.pm line 860.
>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <joonas.kylmala@helsinki.fi>
>---
> C4/Reserves.pm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/C4/Reserves.pm b/C4/Reserves.pm
>index e2aed57a77..8efa426d12 100644
>--- a/C4/Reserves.pm
>+++ b/C4/Reserves.pm
>@@ -853,11 +853,11 @@ sub CheckReserves {
> 
>         my $priority = 10000000;
>         foreach my $res (@reserves) {
>-            if ($res->{'found'} eq 'W') {
>+            if ($res->{'found'} && $res->{'found'} eq 'W') {
>                 return ( "Waiting", $res, \@reserves ); # Found it, it is waiting
>-            } elsif ($res->{'found'} eq 'P') {
>+            } elsif ($res->{'found'} && $res->{'found'} eq 'P') {
>                 return ( "Processing", $res, \@reserves ); # Found determinated hold, e. g. the transferred one
>-            } elsif ($res->{'found'} eq 'T') {
>+            } elsif ($res->{'found'} && $res->{'found'} eq 'T') {
>                 return ( "Transferred", $res, \@reserves ); # Found determinated hold, e. g. the transferred one
>             } else {
>                 my $patron;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25690: 116948 | 116949 | 116950 | 116951 | 117000 | 117001 | 117002 | 117003 | 117004 | 117062 | 117063 | 117064 | 117065 | 117066 | 117067 | 117374 | 117507 | 117508 | 117509 | 117510 | 117511 | 117512 | 117513 | 117519 | 117520 | 117521 | 117522 | 117523 | 117524 | 117525 | 117674