Attachment 117682 Details for Bug 27855 – Bug 27855: Implement Koha::Patron::Attribute->to_api_mapping

[patch] Bug 27855: Implement Koha::Patron::Attribute->to_api_mapping

Bug-27855-Implement-KohaPatronAttribute-toapimappi.patch (text/plain), 1.29 KB, created by Kyle M Hall (khall) on 2021-03-04 11:41:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2021-03-04 11:41:21 UTC

Size: 1.29 KB

patch

obsolete

>From 4480821316b5411b0608f769b7e36fdc6dcd3a74 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Wed, 3 Mar 2021 16:51:41 -0300
>Subject: [PATCH] Bug 27855: Implement Koha::Patron::Attribute->to_api_mapping
>
>This patch introduces a mapping to render extended attributes on the
>API. As they have an ID, and they will generally be used on the
>/patrons umbrella, I removed the borrowernumber on the mapping.
>
>Another option would be to add the field, but make it optional. It
>really feels redundant, so I take it out for now.
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> Koha/Patron/Attribute.pm | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
>diff --git a/Koha/Patron/Attribute.pm b/Koha/Patron/Attribute.pm
>index 5afd674149..115b7bad46 100644
>--- a/Koha/Patron/Attribute.pm
>+++ b/Koha/Patron/Attribute.pm
>@@ -112,6 +112,21 @@ sub description {
>     return $self->attribute;
> }
> 
>+=head3 to_api_mapping
>+
>+This method returns the mapping for representing a Koha::Patron::Attribute object
>+on the API.
>+
>+=cut
>+
>+sub to_api_mapping {
>+    return {
>+        id             => 'extended_attribute_id',
>+        attribute      => 'value',
>+        borrowernumber => undef,
>+        code           => 'type'
>+    };
>+}
> 
> =head2 Internal methods
> 
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 27855: 117660 | 117661 | 117662 | 117663 | 117681 | 117682 | 117683 | 117684 | 117685 | 117686 | 117687 | 117688 | 117689 | 117690 | 117691 | 117692 | 117693 | 117694 | 117695