Attachment 117775 Details for Bug 27610 – Bug 27610: (follow-up) Hide <h1> on opac-main.tt

[patch] Bug 27610: (follow-up) Hide <h1> on opac-main.tt

Bug-27610-follow-up-Hide-h1-on-opac-maintt.patch (text/plain), 1.94 KB, created by Hayley Pelham on 2021-03-05 01:02:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hayley Pelham

Created: 2021-03-05 01:02:38 UTC

Size: 1.94 KB

patch

obsolete

>From 475c591c2c02267bc182ec620455801fbda70db0 Mon Sep 17 00:00:00 2001
>From: Hayley Pelham <hayleypelham@catalyst.net.nz>
>Date: Fri, 5 Mar 2021 00:08:53 +0000
>Subject: [PATCH] Bug 27610: (follow-up) Hide <h1> on opac-main.tt
>
>This patch visually hides the <h1> on opac-main.tt so that libraries'
>customisations of their home pages are not disturbed by the introduction
>of a descriptive <h1>, but the heading is still available to be read out
>by screenreaders in the summary of headings on the page.
>
>Test plan:
>1) Apply dependencies and all patches on this bug report
>2) Observe a new heading level 1 'Home' on the OPAC main page
>2) Apply this patch
>3) Observe the heading is hidden visually, but in the source code you can see it
>is in the correct hierarchy and it is more descriptive 'Koha home'
>
>Sponsored-by: Catalyst IT
>---
> koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss       | 5 +++++
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt | 2 +-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>index 8f411ae789..5b4a1e5da7 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>@@ -2596,4 +2596,9 @@ $star-selected: #EDB867;
>     }
> }
> 
>+/* Hidden headings for accessibility */
>+.opac-hidden-heading {
>+  display: none;
>+}
>+
> @import "responsive";
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
>index 3f059a2fee..de000b2b82 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
>@@ -66,7 +66,7 @@
>             <div class="col order-md-1 maincontent">
>         [% END %]
> 
>-        <h1>Home</h1>
>+        <h1 class="opac-hidden-heading">Koha home</h1>
> 
>         [% IF Koha.Preference( 'OpacNewsLibrarySelect' ) %]
>             [% UNLESS news_item %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27610: 116296 | 117017 | 117769 | 117772 | 117773 | 117774 | 117775 | 118084 | 118445 | 118446 | 118447 | 118449 | 118450 | 118451 | 118773 | 118774 | 118775