Bugzilla – Attachment 11778 Details for
Bug 8438
Allow staff to only claim serial issues of their own branch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8438: Users can only claim for serials related to their branch.
Bug-8438-Users-can-only-claim-for-serials-related-.patch (text/plain), 2.55 KB, created by
Jonathan Druart
on 2012-08-23 11:53:18 UTC
(
hide
)
Description:
Bug 8438: Users can only claim for serials related to their branch.
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2012-08-23 11:53:18 UTC
Size:
2.55 KB
patch
obsolete
>From 73aba457961f9d74d58d4c1397407b4220007880 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Thu, 23 Aug 2012 13:53:21 +0200 >Subject: [PATCH] Bug 8438: Users can only claim for serials related to their > branch. > >Only superlibrarian users and users with superserials permission >can override this limitation. >The original author of this patch is Julian Maurice. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt | 8 +++++--- > serials/claims.pl | 12 +++++++++++- > 2 files changed, 16 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt >index b47b51b..cb82e27 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt >@@ -262,9 +262,11 @@ > <tbody>[% FOREACH missingissue IN missingissues %] > <tr> > [% IF ( letter ) %] >- <td> >- <input type="checkbox" name="serialid" value="[% missingissue.serialid %]" /> >- </td> >+ <td> >+ [% UNLESS missingissue.cannot_claim %] >+ <input type="checkbox" name="serialid" value="[% missingissue.serialid %]" /> >+ [% END %] >+ </td> > [% END %] > <td> > [% missingissue.name %] >diff --git a/serials/claims.pl b/serials/claims.pl >index 1b97a1b..95f9fd8 100755 >--- a/serials/claims.pl >+++ b/serials/claims.pl >@@ -39,7 +39,7 @@ my $suppliername = $input->param('suppliername'); > my $order = $input->param('order'); > > # open template first (security & userenv set here) >-my ($template, $loggedinuser, $cookie) >+my ($template, $loggedinuser, $cookie, $flags) > = get_template_and_user({template_name => 'serials/claims.tmpl', > query => $input, > type => 'intranet', >@@ -71,6 +71,16 @@ if ($supplierid) { > @supplierinfo=GetBookSeller($supplierid); > } > >+unless( $flags->{superlibrarian} == 1 >+ || $template->{param_map}->{CAN_user_serials_superserials} ){ >+ foreach (@missingissues) { >+ if( $_->{branchcode} >+ and $_->{branchcode} ne C4::Context->userenv->{'branch'} ) { >+ $_->{cannot_claim} = 1; >+ } >+ } >+} >+ > my $branchloop = GetBranchesLoop(); > unshift @$branchloop, {value=> 'all',name=>''}; > >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8438
:
11778
|
12842
|
24074
|
26399
|
26400
|
29098
|
29099
|
29191
|
29192
|
29211
|
29212
|
35177
|
35178
|
35305
|
35306
|
35311
|
35312
|
43560