Bugzilla – Attachment 117839 Details for
Bug 27851
Add Koha::Old::Checkouts->filter_by_todays_checkins method
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27851: Use filter_by_todays_checkins in members/readingrec.pl
Bug-27851-Use-filterbytodayscheckins-in-membersrea.patch (text/plain), 2.76 KB, created by
Martin Renvoize (ashimema)
on 2021-03-05 12:16:09 UTC
(
hide
)
Description:
Bug 27851: Use filter_by_todays_checkins in members/readingrec.pl
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-03-05 12:16:09 UTC
Size:
2.76 KB
patch
obsolete
>From d7808317b20078860850ecb6febee404eb5cb20a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 5 Mar 2021 11:45:12 +0100 >Subject: [PATCH] Bug 27851: Use filter_by_todays_checkins in > members/readingrec.pl > >Test plan: >Do some checkouts >Checkin with different return dates (several today however) >Check the circulation history and confirm that the checkout list is correct > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > members/readingrec.pl | 31 ++++++++++++++++--------------- > 1 file changed, 16 insertions(+), 15 deletions(-) > >diff --git a/members/readingrec.pl b/members/readingrec.pl >index d484e69bf8..c8fddf3379 100755 >--- a/members/readingrec.pl >+++ b/members/readingrec.pl >@@ -56,27 +56,16 @@ if ($input->param('borrowernumber')) { > my $logged_in_user = Koha::Patrons->find( $loggedinuser ); > output_and_exit_if_error( $input, $cookie, $template, { module => 'members', logged_in_user => $logged_in_user, current_patron => $patron } ); > >-my $order = 'date_due desc'; >-my $limit = 0; >-my $issues = (); >-# Do not request the old issues of anonymous patron >-if ( $patron->borrowernumber eq C4::Context->preference('AnonymousPatron') ){ >- # use of 'eq' in the above comparison is intentional -- the >- # system preference value could be blank >- $template->param( is_anonymous => 1 ); >-} else { >- $issues = GetAllIssues($patron->borrowernumber,$order,$limit); >-} >- > # barcode export > if ( $op eq 'export_barcodes' ) { > # FIXME This should be moved out of this script > if ( $patron->privacy < 2) { >- my $today = output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }); >- my @barcodes = >- map { $_->{barcode} } grep { $_->{returndate} =~ m/^$today/o } @{$issues}; >+ my @barcodes = $patron->old_checkouts->search( {}, { prefetch => 'item' } ) >+ ->filter_by_todays_checkins->get_column('item.barcode'); >+ > my $borrowercardnumber = $patron->cardnumber; > my $delimiter = "\n"; >+ my $today = dt_from_string->ymd; > binmode( STDOUT, ":encoding(UTF-8)" ); > print $input->header( > -type => 'application/octet-stream', >@@ -90,6 +79,18 @@ if ( $op eq 'export_barcodes' ) { > } > } > >+my $order = 'date_due desc'; >+my $limit = 0; >+my $issues = (); >+# Do not request the old issues of anonymous patron >+if ( $patron->borrowernumber eq C4::Context->preference('AnonymousPatron') ){ >+ # use of 'eq' in the above comparison is intentional -- the >+ # system preference value could be blank >+ $template->param( is_anonymous => 1 ); >+} else { >+ $issues = GetAllIssues($patron->borrowernumber,$order,$limit); >+} >+ > if (! $limit){ > $limit = 'full'; > } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27851
:
117800
|
117801
|
117802
|
117803
|
117822
|
117823
|
117824
|
117825
|
117826
|
117827
|
117828
|
117836
|
117837
|
117838
| 117839