Bugzilla – Attachment 117866 Details for
Bug 27781
Editing Codes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27881: Markup error in masthead-langmenu.inc
Bug-27881-Markup-error-in-masthead-langmenuinc.patch (text/plain), 5.00 KB, created by
Owen Leonard
on 2021-03-05 15:41:03 UTC
(
hide
)
Description:
Bug 27881: Markup error in masthead-langmenu.inc
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2021-03-05 15:41:03 UTC
Size:
5.00 KB
patch
obsolete
>From 700883630c43ed10adec6513c3cc3e51e8a5cf5c Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 5 Mar 2021 15:33:02 +0000 >Subject: [PATCH] Bug 27881: Markup error in masthead-langmenu.inc > >Some markup errors were introduced into the masthead-langmenu include >file by Bug 20168, presumably during the update to the dropdown menu >markup: > >'<a class="dropdown-item" <a href="' > >...resulting in validation errors like "Attribute <a not allowed on >element a at this point." This patch correct the errors. > >To test you should have at least two languages enabled in the >OPACLanguages system preference, opaclanguagesdisplay set to "allow," >and OpacLangSelectorMode set to "top" or "both top and footer." > >- Apply the patch and view the OPAC. >- The "Languages" menu at the top of the page should look correct and > work correctly. >- Validating the source of the page should return no errors related to > the language menu's markup. > >https://bugs.koha-community.org/show_bug.cgi?id=27781 >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc >index a578f3275c..c80d978837 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc >@@ -11,16 +11,16 @@ > [% FOREACH sublanguages_loo IN languages_loo.sublanguages_loop %] > [% IF ( sublanguages_loo.enabled ) %] > [% IF ( sublanguages_loo.sublanguage_current ) %] >- <a class="dropdown-item" <a href="#" tabindex="-1" role="menuitem">[% sublanguages_loo.native_description | html %] [% sublanguages_loo.script_description | html %] [% sublanguages_loo.region_description | html %] [% sublanguages_loo.variant_description | html %] <i class="fa fa-check" aria-hidden="true"></i></a> >+ <a class="dropdown-item" href="#" tabindex="-1" role="menuitem">[% sublanguages_loo.native_description | html %] [% sublanguages_loo.script_description | html %] [% sublanguages_loo.region_description | html %] [% sublanguages_loo.variant_description | html %] <i class="fa fa-check" aria-hidden="true"></i></a> > [% ELSE %] >- <a class="dropdown-item"<a href="/cgi-bin/koha/opac-changelanguage.pl?language=[% sublanguages_loo.rfc4646_subtag | uri %]" tabindex="-1" role="menuitem"> [% sublanguages_loo.native_description | html %] [% sublanguages_loo.script_description | html %] [% sublanguages_loo.region_description | html %] [% sublanguages_loo.variant_description | html %]</a> >+ <a class="dropdown-item" href="/cgi-bin/koha/opac-changelanguage.pl?language=[% sublanguages_loo.rfc4646_subtag | uri %]" tabindex="-1" role="menuitem"> [% sublanguages_loo.native_description | html %] [% sublanguages_loo.script_description | html %] [% sublanguages_loo.region_description | html %] [% sublanguages_loo.variant_description | html %]</a> > [% END # /IF ( sublanguages_loo.sublanguage_current ) %] > [% END # / IF sublanguages_loo.enabled %] > [% END # / FOREACH sublanguages_loo %] > [% ELSE %] > [% IF ( languages_loo.group_enabled ) %] > [% IF ( languages_loo.current ) %] >- <a class="dropdown-item"<a href="#" tabindex="-1" class="menu-inactive" role="menuitem"> >+ <a class="dropdown-item" href="#" tabindex="-1" class="menu-inactive" role="menuitem"> > [% IF ( languages_loo.native_description ) %] > [% languages_loo.native_description | html %] > [% ELSE %] >@@ -28,7 +28,7 @@ > [% END %] <i class="fa fa-check" aria-hidden="true"></i> > </a> > [% ELSE %] >- <a class="dropdown-item"<a href="/cgi-bin/koha/opac-changelanguage.pl?language=[% languages_loo.rfc4646_subtag | uri %]" tabindex="-1" role="menuitem"> >+ <a class="dropdown-item" href="/cgi-bin/koha/opac-changelanguage.pl?language=[% languages_loo.rfc4646_subtag | uri %]" tabindex="-1" role="menuitem"> > [% IF ( languages_loo.native_description ) %] > [% languages_loo.native_description | html %] > [% ELSE %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27781
:
117866