Attachment 117888 Details for Bug 27890 – Bug 27890: Select new macro after creation

[patch] Bug 27890: Select new macro after creation

Bug-27890-Select-new-macro-after-creation.patch (text/plain), 1.51 KB, created by David Nind on 2021-03-06 21:12:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2021-03-06 21:12:37 UTC

Size: 1.51 KB

patch

obsolete

>From b565ae96260da76c26639672c04b29a6f839ab31 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Sat, 6 Mar 2021 15:37:48 +0000
>Subject: [PATCH] Bug 27890: Select new macro after creation
>
>There was an error here, we were capturing the status of the request (i.e. success)
>instead of the returned data.
>
>To test:
> 1 - Go to Cataloguing -> Advanced editor
> 2 - Click 'Macros'
> 3 - 'New macro..'
> 4 - Assing a name and click 'Ok'
> 5 - New macro is in list on left, but not selected
> 6 - Type into editor, no save feedback after typing
> 7 - Apply patch
> 8 - Reload the editor
> 9 - Repeat 3-4
>10 - New macro is selected
>11 - Type into editor, save notification appears
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
>index 39f03f75b5..352e9a0c53 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
>@@ -902,7 +902,7 @@ require( [ 'koha-backend', 'search', 'macros', 'marc-editor', 'marc-record', 'pr
>                 })
>             };
>             $.ajax(options)
>-                .then(function(undef, result) {
>+                .then(function(result) {
>                     showSavedMacros();
>                     loadMacro( result.name, result.macro_id );
>                 })
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27890: 117885 | 117888 | 117890