Attachment 117928 Details for Bug 27896 – BUg 27896: Remove DeleteTransfer

[patch] BUg 27896: Remove DeleteTransfer

BUg-27896-Remove-DeleteTransfer.patch (text/plain), 2.55 KB, created by Martin Renvoize (ashimema) on 2021-03-08 15:31:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-03-08 15:31:11 UTC

Size: 2.55 KB

patch

obsolete

>From 55532336e6d4514373bf847ca1d2eaf276d18181 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Mon, 8 Mar 2021 15:30:09 +0000
>Subject: [PATCH] BUg 27896: Remove DeleteTransfer
>
>This patch removes the last mentions of DeleteTransfer
>
>Test plan
>1/ Grep the codebase for DeleteTransfer
>2/ It should no longer exist
>---
> C4/Circulation.pm                      | 19 -------------------
> t/db_dependent/Circulation/transfers.t |  7 -------
> 2 files changed, 26 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index c166341597..b7668bb191 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -120,7 +120,6 @@ BEGIN {
> 		&GetTransfers
> 		&GetTransfersFromTo
> 		&updateWrongTransfer
>-		&DeleteTransfer
>                 &IsBranchTransferAllowed
>                 &CreateBranchTransferLimit
>                 &DeleteBranchTransferLimits
>@@ -3502,24 +3501,6 @@ sub GetTransfersFromTo {
>     return (@gettransfers);
> }
> 
>-=head2 DeleteTransfer
>-
>-  &DeleteTransfer($itemnumber);
>-
>-=cut
>-
>-sub DeleteTransfer {
>-    my ($itemnumber) = @_;
>-    return unless $itemnumber;
>-    my $dbh          = C4::Context->dbh;
>-    my $sth          = $dbh->prepare(
>-        "DELETE FROM branchtransfers
>-         WHERE itemnumber=?
>-         AND datearrived IS NULL "
>-    );
>-    return $sth->execute($itemnumber);
>-}
>-
> =head2 SendCirculationAlert
> 
> Send out a C<check-in> or C<checkout> alert using the messaging system.
>diff --git a/t/db_dependent/Circulation/transfers.t b/t/db_dependent/Circulation/transfers.t
>index c22992d381..19e5d86c40 100755
>--- a/t/db_dependent/Circulation/transfers.t
>+++ b/t/db_dependent/Circulation/transfers.t
>@@ -38,7 +38,6 @@ can_ok(
>     qw(
>       CreateBranchTransferLimit
>       DeleteBranchTransferLimits
>-      DeleteTransfer
>       GetTransfers
>       GetTransfersFromTo
>       )
>@@ -223,12 +222,6 @@ is(
> is(C4::Circulation::DeleteBranchTransferLimits(),undef,"Without parameters DeleteBranchTransferLimit returns undef");
> is(C4::Circulation::DeleteBranchTransferLimits('B'),'0E0',"With a wrong id DeleteBranchTransferLimit returns 0E0");
> 
>-#Test DeleteTransfer
>-is( C4::Circulation::DeleteTransfer($item_id1),
>-    1, "A the item1's transfer has been deleted" );
>-is(C4::Circulation::DeleteTransfer(),undef,"Without itemid DeleteTransfer returns undef");
>-is(C4::Circulation::DeleteTransfer(-1),'0E0',"with a wrong itemid DeleteTranfer returns 0E0");
>-
> #Test TransferSlip
> is( C4::Circulation::TransferSlip($branchcode_1, undef, 5, $branchcode_2),
>     undef, "No tranferslip if invalid or undef itemnumber or barcode" );
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27896: 117927 | 117928 | 119345 | 119347 | 119348 | 119349 | 119758 | 119759 | 119760 | 119761