Attachment 11795 Details for Bug 8449 – [SIGNED-OFF] Bug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen

[patch] [SIGNED-OFF] Bug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen

SIGNED-OFF-Bug-8449---Improve-wording-and-styling-.patch (text/plain), 3.18 KB, created by Nicole C. Engard on 2012-08-23 16:00:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nicole C. Engard

Created: 2012-08-23 16:00:13 UTC

Size: 3.18 KB

patch

obsolete

>From 09ebbbe0a7a078aa93b60624cd0351163a4cc5fe Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 23 Aug 2012 11:49:38 -0400
>Subject: [PATCH] [SIGNED-OFF] Bug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen
>
>This patch re-implements and adapts the changes dcook@prosentient.com.au
>submitted in a patch which no longer applies. I have changed the
>"alert" style messages to "message" style to match the style
>which is applied to "hold found" messages elsewhere.
>
>I have also revised the language in a way that I think is more
>clear and accurate.
>
>Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
>---
> .../prog/en/modules/circ/waitingreserves.tt        |   19 ++++++++++---------
> 1 files changed, 10 insertions(+), 9 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt
>index ea0faef..8561745 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt
>@@ -47,23 +47,24 @@ $.tablesorter.addParser({
>     [% IF ( cancel_result ) %]
>         [% FOREACH cancel_result %]
>             [% IF ( messagetransfert ) %]
>-                <div>
>-                    <h2>Hold find for ([% nextreservtitle %]), must be transferred</h2>
>-                    <p>This hold placed by : <b> [% nextreservsurname %] [% nextreservfirstname %]</b> at the library : <b> [% branchname %] </b>, Please transfer this hold.
>+                <div class="dialog message">
>+                    <h2>This item is on hold for pick-up at another library</h2>
>+                    <p><strong>[% nextreservtitle %]</strong> is on hold for <strong> [% nextreservsurname %], [% nextreservfirstname %]</strong>.
>+                    Please retain this item and check it in to process the hold.
>                     </p>
>                     <form name="cancelReservewithtransfert" action="waitingreserves.pl" method="post">
>-                        <input type="submit" class="button" />
>+                        <input type="submit" class="submit" value="OK" />
>                     </form>
>                 </div>
>             [% END %]
>             [% IF ( waiting ) %]
>-                <div id="bloc25">
>-                    <h2>This hold is waiting</h2>
>-                    <p>This hold ([% nextreservtitle %]) was placed by <b> : [% nextreservsurname %] [% nextreservfirstname %]</b>,
>-                    Please retain this hold.
>+                <div class="dialog message">
>+                    <h2>This item is on hold for pick-up at your library</h2>
>+                    <p><strong>[% nextreservtitle %]</strong> is on hold for <strong>[% nextreservsurname %], [% nextreservfirstname %]</strong>.
>+                    Please retain this item and check it in to process the hold.
>                     </p>
>                     <form name="cancelReservewithwaiting" action="waitingreserves.pl" method="post">
>-                        <input type="submit" />
>+                        <input type="submit" class="submit" value="OK"/>
>                     </form>
>                 </div>
>             [% END %]
>-- 
>1.7.2.3

Actions: View | Diff | Splinter Review

Attachments on bug 8449: 10879 | 11794 | 11795 | 12637 | 12638