Attachment 118124 Details for Bug 27926 – Bug 27926: Add 'title-string' for dates on circ-patron-results

[patch] Bug 27926: Add 'title-string' for dates on circ-patron-results

Bug-27926-Add-title-string-for-dates-on-circ-patro.patch (text/plain), 2.26 KB, created by ByWater Sandboxes on 2021-03-11 13:59:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ByWater Sandboxes

Created: 2021-03-11 13:59:21 UTC

Size: 2.26 KB

patch

obsolete

>From 18a3175d29a0d1bf79d9cd99424985340d64297c Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 11 Mar 2021 12:15:25 +0000
>Subject: [PATCH] Bug 27926: Add 'title-string' for dates on
> circ-patron-results
>
>This patch adds the title string sorting for the data of birth field in
>the circulation patron results table.  This has the side effect of
>adding a tooltip that displays the date of birth in ISO format, so I'm
>not entirely sure it's the right approach.
>
>Test plan
>1/ Set your date format preferences to British English (dd-mm-yyyy)
>2/ Do a search that will yield multiple patrons via "Check out"
>3/ Try sorting on date of birth and not the order is incorrect.
>4/ Apply the patch
>5/ Refresh the page and try sorting on date again
>6/ The order should now be correct
>7/ Signoff
>
>Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
>---
> .../intranet-tmpl/prog/en/includes/circ-patron-search-results.inc     | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc
>index 0c31cbf291..1a67d38381 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc
>@@ -4,7 +4,7 @@
>         <tr>
>             <th>Name</th>
>             <th>Card number</th>
>-            <th>Date of birth</th>
>+            <th class="title-string">Date of birth</th>
>             <th>Category</th>
>             <th>Library</th>
>             <th>Address</th>
>@@ -26,7 +26,7 @@
>                     <td><a href="[% data_url | url %]">[% borrower.surname | html %], [% borrower.firstname | html %]</a></td>
>             [% END %]
>                 <td>[% borrower.cardnumber | html %]</td>
>-                <td>[% INCLUDE 'patron-age.inc' patron = borrower %]</td>
>+                <td><span title="[% borrower.dateofbirth | html %]">[% INCLUDE 'patron-age.inc' patron = borrower %]</span></td>
>                 <td>[% Categories.GetName( borrower.categorycode ) | html %]</td>
>                 <td>[% Branches.GetName( borrower.branchcode ) | html %]</td>
>                 <td>[% borrower.address | html %]</td>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27926: 118118 | 118124 | 118181 | 119159 | 119160