Attachment 118161 Details for Bug 14233 – Bug 14233: (QA follow-up) Record updated content

[patch] Bug 14233: (QA follow-up) Record updated content

Bug-14233-QA-follow-up-Record-updated-content.patch (text/plain), 1.18 KB, created by Kyle M Hall (khall) on 2021-03-11 17:17:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2021-03-11 17:17:10 UTC

Size: 1.18 KB

patch

obsolete

>From 26096082499f06979cd5e978c1608519b5471dd7 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 24 Feb 2021 12:38:50 +0000
>Subject: [PATCH] Bug 14233: (QA follow-up) Record updated content
>
>We should record the updated template, not the content prior to the
>update.. That way we can properly compare between versions to see the
>changes made.
>
>Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> tools/letter.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/letter.pl b/tools/letter.pl
>index e49e2f1bc2..64fe2ff76e 100755
>--- a/tools/letter.pl
>+++ b/tools/letter.pl
>@@ -316,7 +316,7 @@ sub add_validate {
>             next;
>         }
>         elsif ( $letter and $letter->{message_transport_type} eq $mtt and $letter->{lang} eq $lang ) {
>-            logaction( 'NOTICES', 'MODIFY', $letter->{id}, $letter->{content},
>+            logaction( 'NOTICES', 'MODIFY', $letter->{id}, $content,
>                 'Intranet' )
>               unless ( $content eq $letter->{content} );
>             $dbh->do(
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 14233: 116649 | 116650 | 116651 | 116660 | 116661 | 116662 | 116668 | 116671 | 116672 | 116673 | 116674 | 116713 | 116760 | 116761 | 117251 | 117252 | 117253 | 117254 | 117255 | 117256 | 117257 | 117258 | 117259 | 117294 | 117295 | 117296 | 117297 | 117298 | 117299 | 117300 | 117301 | 117302 | 117303 | 117304 | 117311 | 117312 | 117313 | 117314 | 117315 | 117316 | 117317 | 117318 | 117319 | 117320 | 117321 | 117345 | 118132 | 118133 | 118134 | 118135 | 118136 | 118137 | 118138 | 118139 | 118140 | 118141 | 118142 | 118143 | 118155 | 118156 | 118157 | 118158 | 118159 | 118160 | 118161 | 118162 | 118163 | 118164 | 118165 | 118166 | 118167 | 118323 | 119291 | 119292 | 119293 | 119294 | 119312 | 119313 | 119314 | 119315 | 119359 | 119360 | 119361 | 119362 | 119510