Attachment 118174 Details for Bug 27737 – Bug 27737: (follow-up) Minimal CSS changes to avoid regressions

[patch] Bug 27737: (follow-up) Minimal CSS changes to avoid regressions

Bug-27737-follow-up-Minimal-CSS-changes-to-avoid-r.patch (text/plain), 4.33 KB, created by Phil Ringnalda on 2021-03-12 04:57:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Phil Ringnalda

Created: 2021-03-12 04:57:08 UTC

Size: 4.33 KB

patch

obsolete

>From da1a41de03801469bc699ce80b0ef99f9cbca994 Mon Sep 17 00:00:00 2001
>From: Phil Ringnalda <phil@chetcolibrary.org>
>Date: Mon, 8 Mar 2021 19:33:06 -0800
>Subject: [PATCH] Bug 27737: (follow-up) Minimal CSS changes to avoid
> regressions
>
>To keep the specificity of the rules we want to have apply to both the
>biblio editor and also the authorities editor, we need to add the ID for
>the authorities editor, rather than remove the ID for the biblio editor.
>
>Also, the removal of the selectors for #authoritiestabs descendents was
>regressing the display of authority record details, which is where that
>plural authoritiestabs element lives.
>
>Test plan:
>
>1.  With neither patch from this bug applied, Cataloging - New record -
>    Default framework.
>2.  Shrink and widen your browser window, noticing how the input fields
>    flex to remain the full width, keeping the controls to duplicate and
>    delete a subfield out directly to the right of the input.
>3.  Authorities - search for Perl (or any term that will match a record),
>    click the linked authority term to open the Authority detail display
>4.  Note how the field number, field description, and subfield descriptions
>    are all different colors, and subfield codes are on the same line as
>    the subfield contents.
>5.  Apply both patches from this bug.
>6.  Cataloging - New record - Default framework
>7.  Verify that the input fields still behave the same as you widen and
>    shrink your browser window
>8.  Authorities - New authority - Chronological Term
>9.  Verify that the input fields now behave like the ones in the biblio
>    editor, shrinking and widening to fill the width of the page, keeping
>    the controls to duplicate and delete subfields immediately to the
>    right of the field
>10. Authorities - search for Perl, click the linked authority term to open
>    the Authority detail display
>11. Verify that the tag number, field description and subfield descriptions
>    are still properly colored and subfield codes are still on the same
>    line as the subfield contents.
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Trivial fixup for a copy-paste failure, missed the y on
>subfield_loop_mandator
>---
> .../intranet-tmpl/prog/css/addbiblio.css      | 58 ++++++++++++++++---
> 1 file changed, 50 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css b/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css
>index ddbefa898d..40bf8b9c92 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css
>+++ b/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css
>@@ -159,21 +159,21 @@ a.tagnum {
>     float: left;
> }
> 
>-.subfieldcode {
>+#cat_addbiblio .subfieldcode, #authoritytabs .subfieldcode {
>     float: none;
> }
> 
>-.labelsubfield {
>+#cat_addbiblio .labelsubfield, #authoritytabs .labelsubfield {
>     font-size: 90%;
>     float: none;
> }
> 
>-.subfield {
>+#cat_addbiblio .subfield, #authoritytabs .subfield {
>     float: none;
>     padding: .25em .5em;
> }
> 
>-.subfield label {
>+#cat_addbiblio .subfield label, #authoritytabs .subfield label {
>     color: #00698a;
> }
> 
>@@ -182,21 +182,21 @@ a.tagnum {
> 	width:30em;
> }
> 
>-.input_marceditor {
>+#cat_addbiblio .input_marceditor, #authoritytabs .input_marceditor {
>     float: none;
>     width: 100%;
> }
> 
>-.subfield_line {
>+#cat_addbiblio .subfield_line, #authoritytabs .subfield_line {
>     display: flex;
> }
> 
>-.field_marceditor {
>+#cat_addbiblio .field_marceditor, #authoritytabs .field_marceditor {
>     flex-grow: 1;
>     padding: .25em .5em;
> }
> 
>-.subfield_loop_mandatory {
>+#cat_addbiblio .subfield_loop_mandatory, #authoritytabs .subfield_loop_mandatory {
>     padding: .25em .5em;
> }
> 
>@@ -400,3 +400,45 @@ tbody tr.active td {
>     z-index: 2000;
> }
> 
>+#authoritiestabs .marc_field {
>+    display: inline-block;
>+    padding: .3em;
>+    border-radius: 3px;
>+}
>+
>+#authoritiestabs .marc_subfield {
>+    font-weight: bold;
>+    color: #666;
>+}
>+
>+#authoritiestabs .marc_subfield_desc {
>+    color: #00698a;
>+    font-style: italic;
>+}
>+
>+#authoritiestabs .auth_subfield {
>+    display: flex;
>+}
>+
>+#authoritiestabs .tag {
>+    padding: .4em 0;
>+}
>+
>+#authoritiestabs .tag_desc {
>+    color: #026;
>+}
>+
>+#authoritiestabs .tag_num {
>+    color: #080;
>+}
>+
>+#authoritiestabs .tag_title {
>+    font-size: 100%;
>+    font-weight: bold;
>+    padding: 0;
>+}
>+
>+#authoritiestabs .ui-tabs-nav.ui-widget-header {
>+    border-bottom: 1px solid #b9d8d9;
>+    border-radius: 0;
>+}
>-- 
>2.26.1

Actions: View | Diff | Splinter Review

Attachments on bug 27737: 117544 | 117545 | 117860 | 117862 | 117872 | 117883 | 117884 | 117952 | 118115 | 118116 | 118117 | 118174 | 118179 | 118187 | 118188